feat: trimmed-tests

Author: Zaimwa9

tests/test_flagsmith.py

@@ -924,57 +924,49 @@ def test_track_event_raises_without_config(api_key: str) -> None:
         flagsmith.track_event("purchase")
 
 
-def test_track_event_calls_pipeline_processor(
-    mocker: MockerFixture, api_key: str
-) -> None:
-    config = PipelineAnalyticsConfig(analytics_server_url="http://test/")
-    flagsmith = Flagsmith(environment_key=api_key, pipeline_analytics_config=config)
-
-    mock_record = mocker.patch.object(
-        flagsmith._pipeline_analytics_processor, "record_custom_event"
-    )
-
-    flagsmith.track_event(
-        "purchase",
-        identity_identifier="user1",
-        traits={"plan": "premium"},
-        metadata={"amount": 99},
-    )
-
-    mock_record.assert_called_once_with(
-        event_name="purchase",
-        identity_identifier="user1",
-        traits={"plan": "premium"},
-        metadata={"amount": 99},
-    )
-
-
 @responses.activate()
-def test_get_flag_records_evaluation_event_via_flagsmith(
+def test_pipeline_analytics_records_events(
     mocker: MockerFixture, api_key: str, flags_json: str
 ) -> None:
     config = PipelineAnalyticsConfig(analytics_server_url="http://test/")
     flagsmith = Flagsmith(environment_key=api_key, pipeline_analytics_config=config)
 
-    mock_record = mocker.patch.object(
+    mock_eval = mocker.patch.object(
         flagsmith._pipeline_analytics_processor, "record_evaluation_event"
     )
+    mock_custom = mocker.patch.object(
+        flagsmith._pipeline_analytics_processor, "record_custom_event"
+    )
 
     responses.add(method="GET", url=flagsmith.environment_flags_url, body=flags_json)
     flags = flagsmith.get_environment_flags()
     flags.get_flag("some_feature")
 
-    mock_record.assert_called_once_with(
+    mock_eval.assert_called_once_with(
         flag_key="some_feature",
         enabled=True,
         value="some-value",
         identity_identifier=None,
         traits=None,
     )
 
+    flagsmith.track_event(
+        "purchase",
+        identity_identifier="user1",
+        traits={"plan": "premium"},
+        metadata={"amount": 99},
+    )
+
+    mock_custom.assert_called_once_with(
+        event_name="purchase",
+        identity_identifier="user1",
+        traits={"plan": "premium"},
+        metadata={"amount": 99},
+    )
+
 
 @responses.activate()
-def test_get_identity_flags_passes_identity_and_traits(
+def test_identity_flags_records_evaluation_with_resolved_traits(
     mocker: MockerFixture, api_key: str, identities_json: str
 ) -> None:
     config = PipelineAnalyticsConfig(analytics_server_url="http://test/")
@@ -985,6 +977,8 @@ def test_get_identity_flags_passes_identity_and_traits(
     )
 
     responses.add(method="POST", url=flagsmith.identities_url, body=identities_json)
+    responses.add(method="POST", url=flagsmith.identities_url, body=identities_json)
+
     flags = flagsmith.get_identity_flags("user123", traits={"plan": "premium"})
     flags.get_flag("some_feature")
 
@@ -996,19 +990,8 @@ def test_get_identity_flags_passes_identity_and_traits(
         traits={"plan": "premium"},
     )
 
+    mock_record.reset_mock()
 
-@responses.activate()
-def test_get_identity_flags_resolves_trait_config_values(
-    mocker: MockerFixture, api_key: str, identities_json: str
-) -> None:
-    config = PipelineAnalyticsConfig(analytics_server_url="http://test/")
-    flagsmith = Flagsmith(environment_key=api_key, pipeline_analytics_config=config)
-
-    mock_record = mocker.patch.object(
-        flagsmith._pipeline_analytics_processor, "record_evaluation_event"
-    )
-
-    responses.add(method="POST", url=flagsmith.identities_url, body=identities_json)
     flags = flagsmith.get_identity_flags(
         "user123",
         traits={"plan": {"value": "premium", "transient": True}},

tests/test_models.py

@@ -1,9 +1,7 @@
 import typing
-from unittest import mock
 
 import pytest
 
-from flagsmith.analytics import PipelineAnalyticsProcessor
 from flagsmith.models import Flag, Flags
 from flagsmith.types import SDKEvaluationResult, SDKFlagResult
 
@@ -153,34 +151,6 @@ def test_flag_from_evaluation_result_missing_metadata__raises_expected() -> None
         Flag.from_evaluation_result(flag_result)
 
 
-def test_get_flag_records_pipeline_evaluation_event(
-    pipeline_analytics_processor: PipelineAnalyticsProcessor,
-) -> None:
-    flags = Flags(
-        flags={
-            "my_feature": Flag(
-                enabled=True, value="v1", feature_name="my_feature", feature_id=1
-            )
-        },
-        _pipeline_analytics_processor=pipeline_analytics_processor,
-        _identity_identifier="user123",
-        _traits={"plan": "premium"},
-    )
-
-    with mock.patch.object(
-        pipeline_analytics_processor, "record_evaluation_event"
-    ) as mock_record:
-        flags.get_flag("my_feature")
-
-    mock_record.assert_called_once_with(
-        flag_key="my_feature",
-        enabled=True,
-        value="v1",
-        identity_identifier="user123",
-        traits={"plan": "premium"},
-    )
-
-
 def test_get_flag_without_pipeline_processor() -> None:
     flags = Flags(
         flags={

tests/test_pipeline_analytics.py

@@ -137,19 +137,6 @@ def test_failed_flush_requeues_events(
     assert pipeline_analytics_processor._buffer[0]["event_id"] == "my_flag"
 
 
-@pytest.mark.parametrize(
-    "url, expected_endpoint",
-    [
-        ("http://example.com", "http://example.com/v1/analytics/batch"),
-        ("http://example.com/", "http://example.com/v1/analytics/batch"),
-    ],
-)
-def test_url_trailing_slash_handling(url: str, expected_endpoint: str) -> None:
-    config = PipelineAnalyticsConfig(analytics_server_url=url)
-    processor = PipelineAnalyticsProcessor(config=config, environment_key="key")
-    assert processor._batch_endpoint == expected_endpoint
-
-
 def test_record_custom_event(
     pipeline_analytics_processor: PipelineAnalyticsProcessor,
 ) -> None: