Merge pull request #31 from Flagsmith/feat/segment-in-operator

feat: implement `IN` operator

Author: khvn26

lib/flagsmith/engine/segments/constants.rb

@@ -25,6 +25,7 @@ module Constants
         IS_SET = 'IS_SET'
         IS_NOT_SET = 'IS_NOT_SET'
         MODULO = 'MODULO'
+        IN = 'IN'
 
         CONDITION_OPERATORS = [
           EQUAL,
@@ -37,7 +38,8 @@ module Constants
           NOT_EQUAL,
           REGEX,
           PERCENTAGE_SPLIT,
-          MODULO
+          MODULO,
+          IN
         ].freeze
       end
     end

lib/flagsmith/engine/segments/models.rb

@@ -58,6 +58,7 @@ def match_trait_value?(trait_value)
           # handle some exceptions
           trait_value = Semantic::Version.new(trait_value.gsub(/:semver$/, '')) if @value.is_a?(String) && @value.match?(/:semver$/)
 
+          return match_in_value(trait_value) if @operator == IN
           return match_modulo_value(trait_value) if @operator == MODULO
 
           type_as_trait_value = format_to_type_of(trait_value)
@@ -86,6 +87,12 @@ def match_modulo_value(trait_value)
           false
         end
 
+        def match_in_value(trait_value)
+          return @value.split(',').include?(trait_value.to_s) if trait_value.is_a?(String) || trait_value.is_a?(Integer)
+
+          false
+        end
+
         class << self
           def build(json)
             new(**json.slice(:operator, :value).merge(property: json[:property_]))

spec/engine/unit/segments/models_spec.rb

@@ -79,6 +79,18 @@
   ['MODULO', 2.0, '2|0', true],
   ['MODULO', 'foo', '2|0', false],
   ['MODULO', 'foo', 'foo|bar', false],
+  ['IN', 'foo', '', false],
+  ['IN', 'foo', 'foo,bar', true],
+  ['IN', 'bar', 'foo,bar', true],
+  ['IN', 'ba', 'foo,bar', false],
+  ['IN', 'foo', 'foo', true],
+  ['IN', 1, '1,2,3,4', true],
+  ['IN', 1, '', false],
+  ['IN', 1, '1', true],
+  # Flagsmith's engine does not evaluate `IN` condition for floats/doubles and booleans
+  # due to ambiguous serialization across supported platforms.
+  ['IN', 1.5, '1.5', false],
+  ['IN', false, 'false', false],
 ].freeze
 
 RSpec.describe Flagsmith::Engine::Segments::Condition do