fix: marketing consent should default to True (#5416)

Author: matthewelwell

api/custom_auth/serializers.py

@@ -64,7 +64,7 @@ class Meta(UserCreateSerializer.Meta):  # type: ignore[misc]
             "marketing_consent_given",
             "uuid",
         )
-        read_only_fields = ("is_active", "uuid")
+        read_only_fields = ("is_active", "uuid", "marketing_consent_given")
         write_only_fields = ("sign_up_type",)
         extra_kwargs = {
             "email": {

api/tests/integration/custom_auth/end_to_end/test_custom_auth_integration.py

@@ -3,6 +3,7 @@
 from collections import ChainMap
 
 import pyotp
+import pytest
 from django.conf import settings
 from django.core import mail
 from django.urls import reverse
@@ -701,3 +702,31 @@ def test_cannot_create_superuser_if_any_user_exists(
         "A superuser can only be created through this  endpoint if no other users exist."
     ]
     assert FFAdminUser.objects.filter(email=email).exists() is False
+
+
+@pytest.mark.parametrize("marketing_consent_given", [None, True, False])
+def test_marketing_consent_given_defaults_to_true(
+    api_client: APIClient,
+    marketing_consent_given: bool | None,
+    db: None,
+) -> None:
+    # Given
+    password = FFAdminUser.objects.make_random_password()
+    register_data = {
+        "email": "test@example.com",
+        "password": password,
+        "re_password": password,
+        "first_name": "user",
+        "last_name": "test",
+        "marketing_consent_given": marketing_consent_given,
+    }
+    url = reverse("api-v1:custom_auth:ffadminuser-list")
+
+    # When
+    response = api_client.post(
+        url, data=json.dumps(register_data), content_type="application/json"
+    )
+
+    # Then
+    assert response.status_code == status.HTTP_201_CREATED
+    assert response.json()["marketing_consent_given"] is True

api/tests/unit/integrations/lead_tracking/pipedrive/test_unit_pipedrive_lead_tracker.py

@@ -235,7 +235,7 @@ def test_create_lead_creates_person_if_none_found(db, mocker, settings):  # type
     )
     mock_pipedrive_client.create_organization.assert_not_called()
     mock_pipedrive_client.create_person.assert_called_once_with(
-        user.full_name, user.email, MarketingStatus.NO_CONSENT
+        user.full_name, user.email, MarketingStatus.SUBSCRIBED
     )
 
 

api/users/migrations/0040_default_marketing_consent_given_true.py

@@ -0,0 +1,21 @@
+# Generated by Django 4.2.18 on 2025-05-02 15:36
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("users", "0039_alter_ffadminuser_first_name"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="ffadminuser",
+            name="marketing_consent_given",
+            field=models.BooleanField(
+                default=True,
+                help_text="Determines whether the user has agreed to receive marketing mails",
+            ),
+        ),
+    ]

api/users/models.py

@@ -111,10 +111,13 @@ class FFAdminUser(LifecycleModel, AbstractUser):  # type: ignore[django-manager-
     last_name = models.CharField("last name", max_length=150)
     google_user_id = models.CharField(max_length=50, null=True, blank=True)
     github_user_id = models.CharField(max_length=50, null=True, blank=True)
+
+    # Default to True, since it is covered in our Terms of Service.
     marketing_consent_given = models.BooleanField(
-        default=False,
+        default=True,
         help_text="Determines whether the user has agreed to receive marketing mails",
     )
+
     sign_up_type = models.CharField(
         choices=SignUpType.choices, max_length=100, blank=True, null=True
     )