|
| 1 | +import hashlib |
| 2 | +import json |
| 3 | +from itertools import groupby |
| 4 | +from operator import attrgetter |
| 5 | +from typing import TypedDict |
| 6 | + |
| 7 | +import django.db.models.deletion |
| 8 | +from django.apps.registry import Apps |
| 9 | +from django.db import migrations, models |
| 10 | +from django.db.models import Max |
| 11 | + |
| 12 | + |
| 13 | +class LegacyCodeReference(TypedDict): |
| 14 | + feature_name: str |
| 15 | + file_path: str |
| 16 | + line_number: int |
| 17 | + |
| 18 | + |
| 19 | +class StoredCodeReference(TypedDict): |
| 20 | + file_path: str |
| 21 | + line_number: int |
| 22 | + |
| 23 | + |
| 24 | +def _hash_references(references: list[StoredCodeReference]) -> str: |
| 25 | + return hashlib.md5( |
| 26 | + json.dumps(references, sort_keys=True).encode(), |
| 27 | + usedforsecurity=False, |
| 28 | + ).hexdigest() |
| 29 | + |
| 30 | + |
| 31 | +def migrate_scans_forward(apps: Apps, _: object) -> None: |
| 32 | + """Split each legacy scan into new cardinality (per-repository and per-feature)""" |
| 33 | + |
| 34 | + LegacyScan = apps.get_model("code_references", "FeatureFlagCodeReferencesScan") |
| 35 | + PerFeatureScan = apps.get_model("code_references", "ScannedCodeReferences") |
| 36 | + Repository = apps.get_model("code_references", "VCSRepository") |
| 37 | + Feature = apps.get_model("features", "Feature") |
| 38 | + |
| 39 | + legacy_scans_summaries = LegacyScan.objects.values( |
| 40 | + "project_id", |
| 41 | + "repository_url", |
| 42 | + "vcs_provider", |
| 43 | + ).annotate(last_scanned_at=Max("created_at")) |
| 44 | + |
| 45 | + repositories = { |
| 46 | + (summary["project_id"], summary["repository_url"]): Repository.objects.create( |
| 47 | + project_id=summary["project_id"], |
| 48 | + url=summary["repository_url"], |
| 49 | + vcs_provider=summary["vcs_provider"], |
| 50 | + last_scanned_at=summary["last_scanned_at"], |
| 51 | + ) |
| 52 | + for summary in legacy_scans_summaries |
| 53 | + } |
| 54 | + |
| 55 | + # Oldest-first per project so the newest scan wins on hash collisions |
| 56 | + legacy_scans = LegacyScan.objects.order_by("project_id", "created_at").iterator() |
| 57 | + grouped_scans = groupby(legacy_scans, key=attrgetter("project_id")) |
| 58 | + for project_id, project_scans in grouped_scans: |
| 59 | + features = { |
| 60 | + (feature.project_id, feature.name): feature |
| 61 | + for feature in Feature.objects.filter( |
| 62 | + project_id=project_id, |
| 63 | + deleted_at__isnull=True, # Historical models drop SoftDeleteManager |
| 64 | + ) |
| 65 | + } |
| 66 | + for legacy_scan in project_scans: |
| 67 | + repository_url = legacy_scan.repository_url |
| 68 | + repository = repositories[project_id, repository_url] |
| 69 | + |
| 70 | + references_by_feature: dict[str, list[StoredCodeReference]] = {} |
| 71 | + for reference in legacy_scan.code_references: |
| 72 | + feature_name = reference["feature_name"] |
| 73 | + references_by_feature.setdefault(feature_name, []).append( |
| 74 | + StoredCodeReference( |
| 75 | + file_path=reference["file_path"], |
| 76 | + line_number=reference["line_number"], |
| 77 | + ) |
| 78 | + ) |
| 79 | + |
| 80 | + for feature_name, references in references_by_feature.items(): |
| 81 | + if not (feature := features.get((project_id, feature_name))): |
| 82 | + continue |
| 83 | + PerFeatureScan.objects.update_or_create( |
| 84 | + feature=feature, |
| 85 | + repository=repository, |
| 86 | + code_references_hash=_hash_references(references), |
| 87 | + defaults={ |
| 88 | + "revision": legacy_scan.revision, |
| 89 | + "code_references": references, |
| 90 | + "created_at": legacy_scan.created_at, |
| 91 | + }, |
| 92 | + ) |
| 93 | + |
| 94 | + |
| 95 | +def migrate_scans_backward(apps: Apps, _: object) -> None: |
| 96 | + """Mirror each per-feature row back into the legacy single-table layout.""" |
| 97 | + LegacyScan = apps.get_model("code_references", "FeatureFlagCodeReferencesScan") |
| 98 | + PerFeatureScan = apps.get_model("code_references", "ScannedCodeReferences") |
| 99 | + LegacyScan._meta.get_field("created_at").auto_now_add = False |
| 100 | + |
| 101 | + per_feature_scans = PerFeatureScan.objects.select_related( |
| 102 | + "repository", |
| 103 | + "feature", |
| 104 | + ).iterator(chunk_size=200) |
| 105 | + |
| 106 | + for per_feature_scan in per_feature_scans: |
| 107 | + repository = per_feature_scan.repository |
| 108 | + feature_name = per_feature_scan.feature.name |
| 109 | + LegacyScan.objects.create( |
| 110 | + project_id=repository.project_id, |
| 111 | + repository_url=repository.url, |
| 112 | + vcs_provider=repository.vcs_provider, |
| 113 | + revision=per_feature_scan.revision, |
| 114 | + code_references=[ |
| 115 | + {"feature_name": feature_name, **reference} |
| 116 | + for reference in per_feature_scan.code_references |
| 117 | + ], |
| 118 | + created_at=per_feature_scan.created_at, |
| 119 | + ) |
| 120 | + |
| 121 | + |
| 122 | +class Migration(migrations.Migration): |
| 123 | + dependencies = [ |
| 124 | + ("code_references", "0002_add_project_repo_created_index"), |
| 125 | + ("features", "0066_constrain_feature_type"), |
| 126 | + ("projects", "0029_bump_default_project_limits"), |
| 127 | + ] |
| 128 | + |
| 129 | + operations = [ |
| 130 | + migrations.CreateModel( |
| 131 | + name="VCSRepository", |
| 132 | + fields=[ |
| 133 | + ( |
| 134 | + "id", |
| 135 | + models.AutoField( |
| 136 | + auto_created=True, |
| 137 | + primary_key=True, |
| 138 | + serialize=False, |
| 139 | + verbose_name="ID", |
| 140 | + ), |
| 141 | + ), |
| 142 | + ("created_at", models.DateTimeField(auto_now_add=True)), |
| 143 | + ("url", models.URLField()), |
| 144 | + ( |
| 145 | + "vcs_provider", |
| 146 | + models.CharField( |
| 147 | + choices=[("github", "GitHub")], |
| 148 | + max_length=50, |
| 149 | + ), |
| 150 | + ), |
| 151 | + ("last_scanned_at", models.DateTimeField(null=True)), |
| 152 | + ( |
| 153 | + "project", |
| 154 | + models.ForeignKey( |
| 155 | + on_delete=django.db.models.deletion.CASCADE, |
| 156 | + related_name="vcs_repositories", |
| 157 | + to="projects.project", |
| 158 | + ), |
| 159 | + ), |
| 160 | + ], |
| 161 | + ), |
| 162 | + migrations.AddConstraint( |
| 163 | + model_name="vcsrepository", |
| 164 | + constraint=models.UniqueConstraint( |
| 165 | + fields=("project", "url"), |
| 166 | + name="unique_vcs_repository", |
| 167 | + ), |
| 168 | + ), |
| 169 | + migrations.CreateModel( |
| 170 | + name="ScannedCodeReferences", |
| 171 | + fields=[ |
| 172 | + ( |
| 173 | + "id", |
| 174 | + models.AutoField( |
| 175 | + auto_created=True, |
| 176 | + primary_key=True, |
| 177 | + serialize=False, |
| 178 | + verbose_name="ID", |
| 179 | + ), |
| 180 | + ), |
| 181 | + ("created_at", models.DateTimeField()), |
| 182 | + ("revision", models.CharField(max_length=100)), |
| 183 | + ("code_references", models.JSONField(default=list)), |
| 184 | + ("code_references_hash", models.CharField(max_length=32)), |
| 185 | + ( |
| 186 | + "feature", |
| 187 | + models.ForeignKey( |
| 188 | + on_delete=django.db.models.deletion.CASCADE, |
| 189 | + related_name="scanned_code_references", |
| 190 | + to="features.feature", |
| 191 | + ), |
| 192 | + ), |
| 193 | + ( |
| 194 | + "repository", |
| 195 | + models.ForeignKey( |
| 196 | + on_delete=django.db.models.deletion.CASCADE, |
| 197 | + related_name="scanned_code_references", |
| 198 | + to="code_references.vcsrepository", |
| 199 | + ), |
| 200 | + ), |
| 201 | + ], |
| 202 | + ), |
| 203 | + migrations.AddConstraint( |
| 204 | + model_name="scannedcodereferences", |
| 205 | + constraint=models.UniqueConstraint( |
| 206 | + fields=("feature", "repository", "code_references_hash"), |
| 207 | + name="unique_scanned_code_references", |
| 208 | + ), |
| 209 | + ), |
| 210 | + migrations.AddIndex( |
| 211 | + model_name="scannedcodereferences", |
| 212 | + index=models.Index( |
| 213 | + fields=("feature", "repository", "created_at"), |
| 214 | + name="cr_feature_repo_created_idx", |
| 215 | + ), |
| 216 | + ), |
| 217 | + migrations.RunPython( |
| 218 | + code=migrate_scans_forward, |
| 219 | + reverse_code=migrate_scans_backward, |
| 220 | + ), |
| 221 | + migrations.DeleteModel( |
| 222 | + name="FeatureFlagCodeReferencesScan", |
| 223 | + ), |
| 224 | + ] |
0 commit comments