Compromise on perform_create

Author: emyller

api/segments/serializers.py

@@ -1,4 +1,3 @@
-from functools import cached_property
 from typing import Any
 
 import structlog
@@ -114,30 +113,19 @@ class Meta:
             "rules",
             "metadata",
         ]
-        read_only_fields = ["project"]
-
-    @cached_property
-    def project(self) -> Project:
-        """Resolve the project from the view's URL kwargs"""
-        if self.instance:
-            return self.instance.project
-        try:
-            pk = int(self.context["view"].kwargs["project_pk"])
-        except KeyError as error:
-            raise RuntimeError(
-                "The serializer context is missing a view with project_pk in its URL."
-            ) from error
-        return Project.objects.get(pk=pk)  # type: ignore[no-any-return]
 
     def validate(self, attrs: dict[str, Any]) -> dict[str, Any]:
         attrs = super().validate(attrs)
-        organisation = self.project.organisation
+        project = self.instance.project if self.instance else Project.objects.get(
+            pk=int(self.context["view"].kwargs["project_pk"]),
+        )
+        organisation = project.organisation
 
         self._validate_required_metadata(
-            organisation, attrs.get("metadata", []), project=self.project
+            organisation, attrs.get("metadata", []), project=project
         )
         self._validate_segment_rules_conditions_limit(attrs["rules"])
-        self._validate_project_segment_limit(self.project)
+        self._validate_project_segment_limit(project)
         return attrs
 
     def create(self, validated_data: dict[str, Any]):  # type: ignore[no-untyped-def]

api/segments/views.py

@@ -136,7 +136,7 @@ def get_queryset(self):  # type: ignore[no-untyped-def]
         return queryset
 
     def perform_create(self, serializer: SegmentSerializer) -> None:  # type: ignore[override]
-        serializer.save(project_id=self.kwargs["project_pk"])  # type: ignore[no-untyped-call]
+        serializer.save(project_id=int(self.kwargs["project_pk"]))  # type: ignore[no-untyped-call]
 
     @extend_schema(parameters=[AssociatedFeaturesQuerySerializer])
     @action(

api/tests/unit/segments/test_unit_segments_views.py

@@ -1895,7 +1895,7 @@ def test_create_segment__body_project_differs_from_url__does_not_create_in_other
     other_project = Project.objects.create(name="Other Project", organisation=other_org)
 
     # When
-    admin_client.post(
+    response = admin_client.post(
         f"/api/v1/projects/{project.id}/segments/",
         data={
             "name": "a_wild_pokemon",
@@ -1906,4 +1906,6 @@ def test_create_segment__body_project_differs_from_url__does_not_create_in_other
     )
 
     # Then
+    assert response.status_code == status.HTTP_201_CREATED
+    assert response.json()["project"] == project.id
     assert not Segment.objects.filter(project=other_project).exists()