Skip to content

Commit 6f902de

Browse files
committed
actually fix the thing
1 parent 227b7b2 commit 6f902de

2 files changed

Lines changed: 7 additions & 26 deletions

File tree

api/app/settings/common.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
"django.contrib.contenttypes",
8080
"django.contrib.sessions",
8181
"django.contrib.messages",
82+
"django.contrib.postgres",
8283
"django.contrib.staticfiles",
8384
"django.contrib.humanize",
8485
"rest_framework",

api/conftest.py

Lines changed: 6 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
)
1515
from common.projects.permissions import VIEW_PROJECT
1616
from django.contrib.contenttypes.models import ContentType
17-
from django.contrib.postgres.signals import (
18-
register_type_handlers,
19-
)
2017
from django.core.cache import caches
2118
from django.db.backends.base.creation import TEST_DATABASE_PREFIX
2219
from django.test.utils import setup_databases
@@ -25,7 +22,6 @@
2522
from mypy_boto3_dynamodb.service_resource import DynamoDBServiceResource, Table
2623
from pyfakefs.fake_filesystem import FakeFilesystem
2724
from pytest import FixtureRequest
28-
from pytest_django import DjangoDbBlocker
2925
from pytest_django.fixtures import SettingsWrapper
3026
from pytest_django.plugin import blocking_manager_key
3127
from pytest_mock import MockerFixture
@@ -162,10 +158,7 @@ def fs(fs: FakeFilesystem) -> FakeFilesystem:
162158

163159

164160
@pytest.fixture(scope="session")
165-
def django_db_setup(
166-
request: pytest.FixtureRequest,
167-
django_db_blocker: DjangoDbBlocker,
168-
) -> None:
161+
def django_db_setup(request: pytest.FixtureRequest) -> None:
169162
if (
170163
request.config.option.ci
171164
# xdist worker id is either `gw[0-9]+` or `master`
@@ -174,28 +167,15 @@ def django_db_setup(
174167
# Django's test database clone indices start at 1,
175168
# Pytest's worker indices are 0-based
176169
test_db_suffix = str(int(xdist_worker_id_suffix) + 1)
177-
178-
from django.conf import settings
179-
180-
for db_settings in settings.DATABASES.values():
181-
test_db_name = (
182-
f"{TEST_DATABASE_PREFIX}{db_settings['NAME']}_{test_db_suffix}"
183-
)
184-
db_settings["NAME"] = test_db_name
185-
186170
else:
187171
# Tests are run on main node, which assumes -n0
188-
request.getfixturevalue("django_db_setup") # pragma: no cover
172+
return request.getfixturevalue("django_db_setup") # type: ignore[no-any-return] # pragma: no cover
189173

190-
if request.config.option.ci or request.config.getoption("reuse_db"):
191-
from django.db import connections
174+
from django.conf import settings
192175

193-
# Ensure psycopg type handlers are registered.
194-
# This is necessary for tests that involve `HStoreField`.
195-
for connection in connections.all():
196-
if connection.vendor == "postgresql":
197-
with django_db_blocker.unblock():
198-
register_type_handlers(connection)
176+
for db_settings in settings.DATABASES.values():
177+
test_db_name = f"{TEST_DATABASE_PREFIX}{db_settings['NAME']}_{test_db_suffix}"
178+
db_settings["NAME"] = test_db_name
199179

200180

201181
@pytest.fixture(autouse=True)

0 commit comments

Comments
 (0)