chore: Address review feedback on smoke test workflow

Per review feedback:

- Merge the 3 separate curl checks into a single endpoint loop
- Add --max-time 30 to each curl so they don't hang indefinitely
- Add timeout-minutes: 10 to the job level
- Use continue-on-error: true so a smoke test failure warns but
  doesn't block the PR from merging (non-blocking check)
- Failed checks now emit warnings instead of hard-failing — the
  job still exits non-zero so the status shows, but GitHub won't
  gate merge on it

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: talissoncosta

.github/workflows/frontend-pull-request.yml

@@ -39,6 +39,8 @@ jobs:
   smoke-test:
     name: Vercel Preview Smoke Test
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    continue-on-error: true
     steps:
       - name: Wait for Vercel deployments and smoke test
         env:
@@ -51,22 +53,25 @@ jobs:
             "Preview – flagsmith-frontend-staging"
           )
 
+          FAILED=0
+
           for ENV_NAME in "${ENVIRONMENTS[@]}"; do
             echo "⏳ Waiting for '$ENV_NAME' deployment..."
             URL=""
             for i in $(seq 1 60); do
               # Find the deployment for this commit and environment
-              DEPLOY_ID=$(gh api "repos/$REPO/deployments?sha=$SHA&environment=$(printf '%s' "$ENV_NAME" | jq -sRr @uri)&per_page=1" --jq '.[0].id // empty')
+              DEPLOY_INFO=$(gh api "repos/$REPO/deployments?sha=$SHA&environment=$(printf '%s' "$ENV_NAME" | jq -sRr @uri)&per_page=1" --jq '.[0].id // empty')
 
-              if [ -n "$DEPLOY_ID" ]; then
-                STATE=$(gh api "repos/$REPO/deployments/$DEPLOY_ID/statuses?per_page=1" --jq '.[0].state // empty')
+              if [ -n "$DEPLOY_INFO" ]; then
+                STATE=$(gh api "repos/$REPO/deployments/$DEPLOY_INFO/statuses?per_page=1" --jq '.[0].state // empty')
                 if [ "$STATE" = "success" ]; then
-                  URL=$(gh api "repos/$REPO/deployments/$DEPLOY_ID/statuses?per_page=1" --jq '.[0].environment_url')
+                  URL=$(gh api "repos/$REPO/deployments/$DEPLOY_INFO/statuses?per_page=1" --jq '.[0].environment_url')
                   echo "✅ '$ENV_NAME' deployed at: $URL"
                   break
                 elif [ "$STATE" = "failure" ] || [ "$STATE" = "error" ]; then
-                  echo "❌ '$ENV_NAME' deployment failed with state: $STATE"
-                  exit 1
+                  echo "⚠️ '$ENV_NAME' deployment failed with state: $STATE"
+                  FAILED=1
+                  continue 2
                 fi
               fi
               sleep 10
@@ -77,30 +82,23 @@ jobs:
               continue
             fi
 
-            # Smoke test the deployment
-            echo "🔍 Testing $URL/health ..."
-            STATUS=$(curl -s -o /dev/null -w '%{http_code}' "$URL/health")
-            if [ "$STATUS" != "200" ]; then
-              echo "❌ /health returned $STATUS"
-              exit 1
-            fi
-
-            echo "🔍 Testing $URL/config/project-overrides ..."
-            STATUS=$(curl -s -o /dev/null -w '%{http_code}' "$URL/config/project-overrides")
-            if [ "$STATUS" != "200" ]; then
-              echo "❌ /config/project-overrides returned $STATUS"
-              exit 1
-            fi
-
-            echo "🔍 Testing $URL/ ..."
-            STATUS=$(curl -s -o /dev/null -w '%{http_code}' "$URL/")
-            if [ "$STATUS" != "200" ]; then
-              echo "❌ / returned $STATUS (this is the index page served by the Express server)"
-              exit 1
-            fi
+            # Smoke test: health + config + index in a single pass
+            for ENDPOINT in "/health" "/config/project-overrides" "/"; do
+              echo "🔍 Testing $URL$ENDPOINT ..."
+              STATUS=$(curl -s -o /dev/null -w '%{http_code}' --max-time 30 "$URL$ENDPOINT")
+              if [ "$STATUS" != "200" ]; then
+                echo "⚠️ $ENDPOINT returned $STATUS"
+                FAILED=1
+              fi
+            done
 
-            echo "✅ All smoke tests passed for '$ENV_NAME'"
+            echo "✅ Smoke tests done for '$ENV_NAME'"
             echo ""
           done
 
+          if [ "$FAILED" -ne 0 ]; then
+            echo "⚠️ Some smoke tests failed — see above for details"
+            exit 1
+          fi
+
           echo "🎉 All Vercel preview deployments are healthy"