fix(n+1): fix environment-document n+1 for env_feature_version (#5332)

Author: gagantrivedi

api/environments/models.py

@@ -405,6 +405,7 @@ def _get_environment_document_from_db(
                         "feature",
                         "feature_state_value",
                         "identity",
+                        "environment_feature_version",
                         "identity__environment",
                     ).prefetch_related(
                         Prefetch(

api/tests/unit/environments/test_unit_environments_views_sdk_environment.py

@@ -1,5 +1,6 @@
 from typing import TYPE_CHECKING
 
+import pytest
 from django.urls import reverse
 from flag_engine.segments.constants import EQUAL
 from rest_framework import status
@@ -17,6 +18,7 @@
     FeatureStateValue,
 )
 from features.multivariate.models import MultivariateFeatureOption
+from features.versioning.tasks import enable_v2_versioning
 from projects.models import Project
 from segments.models import Condition, Segment, SegmentRule
 
@@ -26,19 +28,30 @@
     from organisations.models import Organisation
 
 
+@pytest.mark.parametrize(
+    "use_v2_feature_versioning, total_queries", [(True, 16), (False, 15)]
+)
 def test_get_environment_document(
     organisation_one: "Organisation",
     organisation_two: "Organisation",
     organisation_one_project_one: "Project",
     django_assert_num_queries: "DjangoAssertNumQueries",
+    use_v2_feature_versioning: bool,
+    total_queries: int,
 ) -> None:
     # Given
     project = organisation_one_project_one
     project2 = Project.objects.create(
         name="standin_project", organisation=organisation_two
     )
 
-    environment = Environment.objects.create(name="Test Environment", project=project)
+    environment = Environment.objects.create(
+        name="Test Environment",
+        project=project,
+    )
+    if use_v2_feature_versioning:
+        enable_v2_versioning(environment.id)
+
     api_key = EnvironmentAPIKey.objects.create(environment=environment)
     client = APIClient()
     client.credentials(HTTP_X_ENVIRONMENT_KEY=api_key.key)
@@ -126,7 +139,7 @@ def test_get_environment_document(
     url = reverse("api-v1:environment-document")
 
     # When
-    with django_assert_num_queries(15):
+    with django_assert_num_queries(total_queries):
         response = client.get(url)
 
     # Then