fix(Logging): Expand APPLICATION_LOGGERS and fix unnamed loggers (#7256)

Author: khvn26

api/conftest.py

@@ -1,4 +1,3 @@
-import logging
 import os
 import site
 import typing
@@ -1253,23 +1252,6 @@ def superuser_client(superuser: FFAdminUser, client: APIClient):  # type: ignore
     return client
 
 
-@pytest.fixture
-def inspecting_handler() -> logging.Handler:
-    """
-    Fixture used to test the output of logger related output.
-    """
-
-    class InspectingHandler(logging.Handler):
-        def __init__(self, *args, **kwargs) -> None:  # type: ignore[no-untyped-def]
-            super().__init__(*args, **kwargs)
-            self.messages = []  # type: ignore[var-annotated]
-
-        def handle(self, record: logging.LogRecord) -> None:  # type: ignore[override]
-            self.messages.append(self.format(record))
-
-    return InspectingHandler()
-
-
 @pytest.fixture
 def set_github_webhook_secret() -> None:
     from django.conf import settings

api/edge_api/identities/export.py

@@ -13,7 +13,7 @@
 
 EXPORT_EDGE_IDENTITY_PAGINATION_LIMIT = 20000
 
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
 
 
 def export_edge_identity_and_overrides(  # noqa: C901

api/edge_api/management/commands/ensure_identity_traits_blanks.py

@@ -9,7 +9,7 @@
 
 identity_wrapper = DynamoIdentityWrapper()
 
-logger: structlog.BoundLogger = structlog.get_logger()
+logger: structlog.BoundLogger = structlog.get_logger(__name__)
 
 LOG_COUNT_EVERY = 100_000
 

api/environments/dynamodb/wrappers/identity_wrapper.py

@@ -31,7 +31,7 @@
 
     from environments.identities.models import Identity
 
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
 
 
 class DynamoIdentityWrapper(BaseDynamoWrapper):

api/features/views.py

@@ -110,8 +110,7 @@
     get_environment_flags_queryset,
 )
 
-logger = logging.getLogger()
-logger.setLevel(logging.INFO)
+logger = logging.getLogger(__name__)
 
 flags_cache = caches[settings.FLAGS_CACHE_LOCATION]
 

api/pyproject.toml

@@ -76,6 +76,7 @@ addopts = [
   '--dist=worksteal',
 ]
 console_output_style = 'count'
+log_level = 'INFO'
 
 [tool.mypy]
 plugins = ["mypy_django_plugin.main"]

api/scripts/run-docker.sh

@@ -3,7 +3,7 @@ set -e
 
 # common environment variables
 ACCESS_LOG_FORMAT=${ACCESS_LOG_FORMAT:-'%(h)s %(l)s %(u)s %(t)s "%(r)s" %(s)s %(b)s "%(f)s" "%(a)s" %({origin}i)s %({access-control-allow-origin}o)s'}
-APPLICATION_LOGGERS=${APPLICATION_LOGGERS:-"common,features,task_processor,app_analytics,webhooks"}
+APPLICATION_LOGGERS=${APPLICATION_LOGGERS:-"app_analytics,audit,code_references,common,core,dynamodb,edge_api,environments,features,import_export,integrations,oauth2_metadata,organisations,projects,segments,task_processor,users,webhooks,workflows"}
 
 waitfordb() {
   if [ -z "${SKIP_WAIT_FOR_DB}" ]; then

api/segments/serializers.py

@@ -11,7 +11,7 @@
 from projects.models import Project
 from segments.models import Condition, Segment, SegmentRule
 
-logger = structlog.get_logger()
+logger = structlog.get_logger(__name__)
 
 DictList = list[dict[str, Any]]
 

api/segments/views.py

@@ -35,7 +35,7 @@
 if TYPE_CHECKING:
     from users.models import FFAdminUser
 
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
 
 
 @method_decorator(

api/tests/unit/integrations/lead_tracking/hubspot/test_unit_hubspot_client.py

@@ -1,5 +1,4 @@
 import json
-import logging
 import typing
 
 import pytest
@@ -120,13 +119,9 @@ def test_create_lead_form__valid_user_data__submits_form_successfully(
 def test_create_lead_form__api_returns_error__logs_error(
     staff_user: FFAdminUser,
     hubspot_client: HubspotClient,
-    inspecting_handler: logging.Handler,
+    caplog: pytest.LogCaptureFixture,
 ) -> None:
     # Given
-    from integrations.lead_tracking.hubspot.client import logger
-
-    logger.addHandler(inspecting_handler)
-
     hubspot_cookie = "test_hubspot_cookie"
     url = f"{HUBSPOT_ROOT_FORM_URL}/{HUBSPOT_PORTAL_ID}/{HUBSPOT_FORM_ID_SAAS}"
     responses.add(
@@ -141,7 +136,7 @@ def test_create_lead_form__api_returns_error__logs_error(
 
     # Then
     assert response == {"error": "Problem processing."}
-    assert inspecting_handler.messages == [  # type: ignore[attr-defined]
+    assert caplog.messages == [
         "Creating Hubspot lead form for user staff@example.com with hubspot cookie test_hubspot_cookie",
         "Problem posting data to Hubspot's form API due to 400 status code and following response: "
         + '{"error": "Problem processing."}',