fix: disable blanket API throttling in favour of WAF (#6642)

Author: gagantrivedi

api/app/settings/common.py

@@ -302,8 +302,8 @@
 
 LOGIN_THROTTLE_RATE = env("LOGIN_THROTTLE_RATE", "20/min")
 SIGNUP_THROTTLE_RATE = env("SIGNUP_THROTTLE_RATE", "10000/min")
-USER_THROTTLE_RATE = env("USER_THROTTLE_RATE", "500/min")
-MASTER_API_KEY_THROTTLE_RATE = env("MASTER_API_KEY_THROTTLE_RATE", USER_THROTTLE_RATE)
+USER_THROTTLE_RATE = env("USER_THROTTLE_RATE", default=None)
+MASTER_API_KEY_THROTTLE_RATE = env("MASTER_API_KEY_THROTTLE_RATE", default=None)
 DEFAULT_THROTTLE_CLASSES = env.list("DEFAULT_THROTTLE_CLASSES", subcast=str, default=[])
 REST_FRAMEWORK = {
     "DEFAULT_PERMISSION_CLASSES": ["rest_framework.permissions.IsAuthenticated"],

infrastructure/aws/production/ecs-task-definition-web.json

@@ -130,26 +130,6 @@
                     "name": "INFLUXDB_URL",
                     "value": "https://eu-central-1-1.aws.cloud2.influxdata.com"
                 },
-                {
-                    "name": "DEFAULT_THROTTLE_CLASSES",
-                    "value": "core.throttling.UserRateThrottle,core.throttling.MasterAPIKeyUserRateThrottle"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_BACKEND",
-                    "value": "django_redis.cache.RedisCache"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_LOCATION",
-                    "value": "rediss://serverless-redis-cache-c4q8sw.serverless.euw2.cache.amazonaws.com:6379"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_OPTIONS",
-                    "value": "CLIENT_CLASS=core.redis_cluster.SafeRedisClusterClient"
-                },
-                {
-                    "name": "MASTER_API_KEY_THROTTLE_RATE",
-                    "value": "100/sec"
-                },
                 {
                     "name": "OAUTH_CLIENT_ID",
                     "value": "232959427810-br6ltnrgouktp0ngsbs04o14ueb9rch0.apps.googleusercontent.com"

infrastructure/aws/staging/ecs-task-definition-web.json

@@ -194,26 +194,6 @@
                     "name": "INFLUXDB_URL",
                     "value": "https://eu-central-1-1.aws.cloud2.influxdata.com"
                 },
-                {
-                    "name": "DEFAULT_THROTTLE_CLASSES",
-                    "value": "core.throttling.UserRateThrottle,core.throttling.MasterAPIKeyUserRateThrottle"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_BACKEND",
-                    "value": "django_redis.cache.RedisCache"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_LOCATION",
-                    "value": "rediss://serverless-redis-cache-7u3xil.serverless.euw2.cache.amazonaws.com:6379"
-                },
-                {
-                    "name": "USER_THROTTLE_CACHE_OPTIONS",
-                    "value": "CLIENT_CLASS=core.redis_cluster.SafeRedisClusterClient"
-                },
-                {
-                    "name": "MASTER_API_KEY_THROTTLE_RATE",
-                    "value": "10/sec"
-                },
                 {
                     "name": "GITHUB_APP_ID",
                     "value": "811209"