Skip to content

Commit b000f47

Browse files
authored
fix(Segment membership): Read counts off segment.membership_counts (#7601)
1 parent 3fa3d9a commit b000f47

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

frontend/common/types/responses.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ export type Segment = {
174174
project: string | number
175175
feature?: number
176176
metadata: Metadata[] | []
177-
memberships?: SegmentMembership[]
177+
membership_counts?: SegmentMembership[]
178178
}
179179
export type ProjectChangeRequest = Omit<
180180
ChangeRequest,

frontend/web/components/modals/CreateSegment.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ const CreateSegment: FC<CreateSegmentType> = ({
589589
<>
590590
Identities
591591
<SegmentMembershipTotalBadge
592-
memberships={segment.memberships}
592+
memberships={segment.membership_counts}
593593
/>
594594
</>
595595
}
@@ -606,7 +606,7 @@ const CreateSegment: FC<CreateSegmentType> = ({
606606
name={name}
607607
searchInput={searchInput}
608608
setSearchInput={setSearchInput}
609-
memberships={segment.memberships}
609+
memberships={segment.membership_counts}
610610
/>
611611
</div>
612612
</TabItem>

frontend/web/components/segments/SegmentRow/SegmentRow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const SegmentRow: FC<SegmentRowProps> = ({ index, projectId, segment }) => {
8282
{feature && (
8383
<div className='chip chip--xs ml-2'>Feature-Specific</div>
8484
)}
85-
<SegmentMembershipTotalBadge memberships={segment.memberships} />
85+
<SegmentMembershipTotalBadge memberships={segment.membership_counts} />
8686
</Row>
8787
<div className='list-item-subtitle mt-1'>
8888
{description || 'No description'}

0 commit comments

Comments
 (0)