fix(launch-darkly-importer): Rate limit responses with no retry information not expected (#5529)

Author: khvn26

api/integrations/launch_darkly/client.py

@@ -9,6 +9,7 @@
 
 from integrations.launch_darkly import types as ld_types
 from integrations.launch_darkly.constants import (
+    BACKOFF_DEFAULT_RETRY_AFTER_SECONDS,
     BACKOFF_MAX_RETRIES,
     LAUNCH_DARKLY_API_BASE_URL,
     LAUNCH_DARKLY_API_ITEM_COUNT_LIMIT_PER_PAGE,
@@ -41,6 +42,9 @@ def _get_retry_after(exc: RequestException) -> float | None:
                 return float(retry_after)
             if ratelimit_reset := headers.get("X-Ratelimit-Reset"):
                 return float(ratelimit_reset) - timezone_now().timestamp()
+            # We have no retry information, use a default backoff time
+            # of 10 seconds as per LD documentation.
+            return BACKOFF_DEFAULT_RETRY_AFTER_SECONDS
         return None
 
     def _wait_gen() -> Generator[float, None, None]:

api/integrations/launch_darkly/constants.py

@@ -8,3 +8,4 @@
 LAUNCH_DARKLY_IMPORTED_DEFAULT_TAG_LABEL = "Imported"
 
 BACKOFF_MAX_RETRIES = 5
+BACKOFF_DEFAULT_RETRY_AFTER_SECONDS = 10

api/tests/unit/integrations/launch_darkly/test_client.py

@@ -325,3 +325,39 @@ def test_launch_darkly_client__rate_limit_invalid_response__raises_expected(
     # When & Then
     with pytest.raises(HTTPError):
         client.get_project(project_key=project_key)
+
+
+def test_launch_darkly_client__rate_limit_no_headers__waits_expected(
+    request: pytest.FixtureRequest,
+    mocker: MockerFixture,
+    requests_mock: RequestsMockerFixture,
+) -> None:
+    # Given
+    token = "test-token"
+    project_key = "test-project-key"
+
+    mocker.patch(
+        "integrations.launch_darkly.client.BACKOFF_DEFAULT_RETRY_AFTER_SECONDS",
+        new=0.1,
+    )
+
+    example_response_content = (
+        request.path.parent / "example_api_responses/getProject.json"
+    ).read_text()
+    expected_result = json.loads(example_response_content)
+
+    requests_mock.get(
+        "https://app.launchdarkly.com/api/v2/projects/test-project-key",
+        [
+            {"status_code": 429},
+            {"status_code": 200, "text": example_response_content},
+        ],
+    )
+
+    client = LaunchDarklyClient(token=token)
+
+    # When
+    result = client.get_project(project_key=project_key)
+
+    # Then
+    assert result == expected_result