Skip to content

Commit c8e4a2e

Browse files
committed
Fix schema generation warning
1 parent 346d9c8 commit c8e4a2e

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

api/features/views.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,14 @@ def get_feature_by_uuid(request, uuid): # type: ignore[no-untyped-def]
102102
name="list",
103103
decorator=swagger_auto_schema(query_serializer=FeatureQuerySerializer()),
104104
)
105-
@method_decorator(
106-
name="retrieve",
107-
decorator=swagger_auto_schema(responses={200: ProjectFeatureSerializer()}),
108-
)
109105
class FeatureViewSet(viewsets.ModelViewSet): # type: ignore[type-arg]
110106
permission_classes = [FeaturePermissions]
111107
pagination_class = CustomPagination
112108

113109
def get_serializer_class(self): # type: ignore[no-untyped-def]
114110
return {
115111
"list": ListFeatureSerializer,
112+
"retrieve": ProjectFeatureSerializer,
116113
"create": ListFeatureSerializer,
117114
"update": UpdateFeatureSerializer,
118115
"partial_update": UpdateFeatureSerializer,
@@ -208,6 +205,8 @@ def perform_destroy(self, instance): # type: ignore[no-untyped-def]
208205
instance.delete()
209206

210207
def get_serializer_context(self): # type: ignore[no-untyped-def]
208+
if getattr(self, "swagger_fake_view", False):
209+
return None
211210
context = super().get_serializer_context()
212211
feature_states = getattr(self, "_feature_states", {})
213212
project = get_object_or_404(Project.objects.all(), pk=self.kwargs["project_pk"])
@@ -507,8 +506,6 @@ def get_queryset(self): # type: ignore[no-untyped-def]
507506
"""
508507
Override queryset to filter based on provided URL parameters.
509508
"""
510-
if getattr(self, "swagger_fake_view", False):
511-
return FeatureState.objects.none()
512509

513510
environment_api_key = self.kwargs["environment_api_key"]
514511

0 commit comments

Comments
 (0)