fix: get-identities-checks-existing-invalid-identifiers (#6083)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: Zaimwa9

api/environments/identities/constants.py

@@ -2,9 +2,9 @@
 
 from django.core.validators import RegexValidator
 
-RE_VALID_IDENTIFIER = re.compile(r"^[\w!#$%&*+/=?^_`{}|~@.\-]+$")
+RE_VALID_IDENTIFIER = re.compile(r"^[\w !#$%&*+/=?^_`{}|~@.\-]+$")
 
 identifier_regex_validator = RegexValidator(
     regex=RE_VALID_IDENTIFIER,
-    message="Identifier can only contain unicode letters, numbers, and the symbols: ! # $ %% & * + / = ? ^ _ ` { } | ~ @ . -",
+    message="Identifier can only contain unicode letters, numbers, spaces and the symbols: ! # $ %% & * + / = ? ^ _ ` { } | ~ @ . -",
 )

api/environments/identities/migrations/0004_allow_spaces_in_identifiers.py

@@ -0,0 +1,28 @@
+# Generated by Django 4.2.24 on 2025-09-17 16:24
+
+import django.core.validators
+from django.db import migrations, models
+import re
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("identities", "0003_sanitized_identifiers"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="identity",
+            name="identifier",
+            field=models.CharField(
+                max_length=2000,
+                validators=[
+                    django.core.validators.RegexValidator(
+                        message="Identifier can only contain unicode letters, numbers, spaces and the symbols: ! # $ %% & * + / = ? ^ _ ` { } | ~ @ . -",
+                        regex=re.compile("^[\\w !#$%&*+/=?^_`{}|~@.\\-]+$"),
+                    )
+                ],
+            ),
+        ),
+    ]

api/tests/unit/conftest.py

@@ -23,6 +23,7 @@ def pytest_generate_tests(metafunc: pytest.Metafunc) -> None:
             "identifier",
             [
                 "bond...jamesbond",
+                "identity with spaces",
                 "ゴジラ",
                 "ElChapulínColorado",
                 "dalek#6453@skaro.gov",
@@ -36,13 +37,12 @@ def pytest_generate_tests(metafunc: pytest.Metafunc) -> None:
         )
 
     if metafunc.definition.get_closest_marker("invalid_identity_identifiers"):
-        error_message = "Identifier can only contain unicode letters, numbers, and the symbols: ! # $ % & * + / = ? ^ _ ` { } | ~ @ . -"
+        error_message = "Identifier can only contain unicode letters, numbers, spaces and the symbols: ! # $ % & * + / = ? ^ _ ` { } | ~ @ . -"
         metafunc.parametrize(
             ["identifier", "identifier_error_message"],
             [
                 ("", "This field may not be blank."),
                 (" ", "This field may not be blank."),
-                ("or really anything with a whitespace", error_message),
                 ("<script>alert(1)</script>", error_message),
                 ("'; DROP TABLE users;--", error_message),
                 ("'single-quotes'", error_message),