Remove task-definition-family in favour of the family attribute in the TD JSON

matthewelwell · matthewelwell · commit ea97e86249e6 · 2026-02-16T17:44:06.000Z
diff --git a/.github/actions/api-deploy-ecs/action.yml b/.github/actions/api-deploy-ecs/action.yml
@@ -72,7 +72,6 @@ runs:
       uses: aws-actions/amazon-ecs-render-task-definition@v1
       with:
         task-definition: ${{ inputs.aws_task_definitions_directory_path }}/ecs-task-definition-admin-api.json
-        task-definition-family: admin-api
         container-name: flagsmith-api
         image: ${{ inputs.api_ecr_image_url }}
 
@@ -82,7 +81,6 @@ runs:
       uses: aws-actions/amazon-ecs-render-task-definition@v1
       with:
         task-definition: ${{ inputs.aws_task_definitions_directory_path }}/ecs-task-definition-migration.json
-        task-definition-family: sdk-api
         container-name: flagsmith-api-migration
         image: ${{ inputs.api_ecr_image_url }}
 
diff --git a/infrastructure/aws/production/ecs-task-definition-admin-api.json b/infrastructure/aws/production/ecs-task-definition-admin-api.json
@@ -1,5 +1,5 @@
 {
-    "family": "flagsmith-api",
+    "family": "admin-api",
     "networkMode": "awsvpc",
     "executionRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",
     "taskRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",
diff --git a/infrastructure/aws/production/ecs-task-definition-sdk-api.json b/infrastructure/aws/production/ecs-task-definition-sdk-api.json
@@ -1,5 +1,5 @@
 {
-    "family": "flagsmith-api",
+    "family": "sdk-api",
     "networkMode": "awsvpc",
     "executionRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",
     "taskRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",
diff --git a/infrastructure/aws/staging/ecs-task-definition-admin-api.json b/infrastructure/aws/staging/ecs-task-definition-admin-api.json
@@ -1,5 +1,5 @@
 {
-    "family": "flagsmith-api",
+    "family": "admin-api",
     "networkMode": "awsvpc",
     "executionRoleArn": "arn:aws:iam::302456015006:role/task-exec-role-6fb76f6",
     "taskRoleArn": "arn:aws:iam::302456015006:role/task-exec-role-6fb76f6",
diff --git a/infrastructure/aws/staging/ecs-task-definition-sdk-api.json b/infrastructure/aws/staging/ecs-task-definition-sdk-api.json
@@ -1,5 +1,5 @@
 {
-    "family": "flagsmith-api",
+    "family": "sdk-api",
     "networkMode": "awsvpc",
     "executionRoleArn": "arn:aws:iam::302456015006:role/task-exec-role-6fb76f6",
     "taskRoleArn": "arn:aws:iam::302456015006:role/task-exec-role-6fb76f6",

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "family": "flagsmith-api",`
	`2`	`+ "family": "admin-api",`
`3`	`3`	`"networkMode": "awsvpc",`
`4`	`4`	`"executionRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",`
`5`	`5`	`"taskRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "family": "flagsmith-api",`
	`2`	`+ "family": "sdk-api",`
`3`	`3`	`"networkMode": "awsvpc",`
`4`	`4`	`"executionRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",`
`5`	`5`	`"taskRoleArn": "arn:aws:iam::084060095745:role/task-exec-role-741a7e3",`