fix: convert large integers to strings (#5314)

Author: matthewelwell

api/features/constants.py

@@ -10,3 +10,5 @@
 # Tag filtering strategy
 UNION = "UNION"
 INTERSECTION = "INTERSECTION"
+
+MAX_32_BIT_INTEGER = 2_147_483_647

api/features/models.py

@@ -720,22 +720,22 @@ def get_feature_state_value(self, identity: "Identity" = None) -> typing.Any:  #
         )
         return self.get_feature_state_value_by_hash_key(identity_hash_key)  # type: ignore[arg-type]
 
-    def get_feature_state_value_defaults(self) -> dict:  # type: ignore[type-arg]
+    def get_feature_state_value_defaults(self) -> dict[str, typing.Any]:
         if (
             self.feature.initial_value is None
             or self.feature.project.prevent_flag_defaults
         ):
             return {}
 
         value = self.feature.initial_value
-        type = get_value_type(value)
+        type_ = get_value_type(value)
         parse_func = {
             BOOLEAN: get_boolean_from_string,
             INTEGER: get_integer_from_string,
-        }.get(type, lambda v: v)
-        key_name = self.get_feature_state_key_name(type)
+        }.get(type_, lambda v: v)
+        key_name = self.get_feature_state_key_name(type_)
 
-        return {"type": type, key_name: parse_func(value)}  # type: ignore[no-untyped-call]
+        return {"type": type_, key_name: parse_func(value)}
 
     def get_multivariate_feature_state_value(
         self, identity_hash_key: str

api/features/utils.py

@@ -1,4 +1,7 @@
 # Feature State Value Types
+import sys
+
+from features.constants import MAX_32_BIT_INTEGER
 from features.value_types import BOOLEAN, INTEGER, STRING
 
 
@@ -8,34 +11,38 @@ def get_value_type(value: str) -> str:
 
     e.g. "12" -> "int", "12.34" -> "float", etc.
     """
-    if is_integer(value):  # type: ignore[no-untyped-call]
+    if is_32_bit_integer(value):
         return INTEGER
-    elif is_boolean(value):  # type: ignore[no-untyped-call]
+    elif is_boolean(value):
         return BOOLEAN
     else:
         return STRING
 
 
-def is_integer(value):  # type: ignore[no-untyped-def]
+def is_32_bit_integer(value: str) -> bool:
+    return is_integer(value, max_abs_value=MAX_32_BIT_INTEGER)
+
+
+def is_integer(value: str, max_abs_value: int = sys.maxsize) -> bool:
     try:
-        int(value)
-        return True
+        int_value = int(value)
+        return abs(int_value) < max_abs_value
     except ValueError:
         return False
 
 
-def is_boolean(value):  # type: ignore[no-untyped-def]
+def is_boolean(value: str) -> bool:
     return value in ("true", "True", "false", "False")
 
 
-def get_integer_from_string(value):  # type: ignore[no-untyped-def]
+def get_integer_from_string(value: str) -> int:
     try:
         return int(value)
     except ValueError:
         return 0
 
 
-def get_boolean_from_string(value):  # type: ignore[no-untyped-def]
+def get_boolean_from_string(value: str) -> bool:
     if value in ("false", "False"):
         return False
     else:

api/tests/unit/features/test_unit_features_utils.py

@@ -1,5 +1,6 @@
 import pytest
 
+from features.constants import MAX_32_BIT_INTEGER
 from features.utils import get_value_type
 from features.value_types import BOOLEAN, INTEGER, STRING
 
@@ -8,6 +9,8 @@
     "value, expected_type",
     (
         ("1", INTEGER),
+        (f"{MAX_32_BIT_INTEGER + 1}", STRING),
+        (f"{-MAX_32_BIT_INTEGER - 1}", STRING),
         ("a string", STRING),
         ("True", BOOLEAN),
         ("true", BOOLEAN),