fix(API): Remove unused **flagsmith_kwargs from get_openfeature_client

Custom kwargs bypassed get_provider_kwargs() entirely, meaning essential
properties like the API key were never set when kwargs were provided.

Author: khvn26

api/integrations/flagsmith/client.py

@@ -31,11 +31,10 @@
 
 def get_openfeature_client(
     domain: str = DEFAULT_OPENFEATURE_DOMAIN,
-    **flagsmith_kwargs: typing.Any,
 ) -> OpenFeatureClient:
     openfeature_client = openfeature_api.get_client(domain=domain)
     if openfeature_client.get_provider_status() != ProviderStatus.READY:
-        initialise_provider(domain, **(flagsmith_kwargs or get_provider_kwargs()))
+        initialise_provider(domain, **get_provider_kwargs())
     return openfeature_client
 
 

api/tests/unit/integrations/flagsmith/test_unit_flagsmith_client.py

@@ -84,30 +84,6 @@ def test_get_openfeature_client__provider_ready__skips_initialisation(
     mock_openfeature_api.set_provider.assert_not_called()
 
 
-def test_get_openfeature_client__custom_flagsmith_kwargs__passes_to_provider(
-    settings: SettingsWrapper,
-    mocker: MockerFixture,
-    mock_local_file_handler: MagicMock,
-    mock_local_file_handler_class: MagicMock,
-) -> None:
-    # Given
-    settings.FLAGSMITH_ON_FLAGSMITH_SERVER_OFFLINE_MODE = True
-
-    mock_openfeature_api = mocker.patch("integrations.flagsmith.client.openfeature_api")
-    mock_client = mock_openfeature_api.get_client.return_value
-    mock_client.get_provider_status.return_value = ProviderStatus.NOT_READY
-
-    mock_flagsmith_class = mocker.patch("integrations.flagsmith.client.Flagsmith")
-    mocker.patch("integrations.flagsmith.client.FlagsmithProvider")
-
-    # When
-    get_openfeature_client(enable_local_evaluation=False)
-
-    # Then
-    call_args = mock_flagsmith_class.call_args
-    assert call_args.kwargs["enable_local_evaluation"] is False
-
-
 def test_initialise_provider__offline_mode_disabled__initialises_with_server_key(
     settings: SettingsWrapper,
     mocker: MockerFixture,