Skip to content

feat: frontend-clone-segments 🔴 Blocked by #5393#5394

Merged
Zaimwa9 merged 11 commits intomainfrom
feat/frontend-clone-segments
May 29, 2025
Merged

feat: frontend-clone-segments 🔴 Blocked by #5393#5394
Zaimwa9 merged 11 commits intomainfrom
feat/frontend-clone-segments

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 25, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

🔴 Blocked by #5393 (feat/backend-clone-segments)

This PR implements the frontend part to consume the new clone segment API endpoint and allow the duplication of existing segments

  • ⚠️ Introduces new flag clone_segment

  • Reviewed UI to use a dropdown instead of trash button in SegmentRow

  • cloneSegment mutation to consume /api/v1/projects/{projectId}/segments/{segmentId}/clone/ accepting a (required) name as body payload

  • Refactored SegmentsPage to extract SegmentRow

  • Extracted ActionItem as single component, calculateListPosition as utils

How did you test this code?

  • New E2E tests
  • Postman requests
  • Fullstack branch feat/clone-segments-and-feature-segments
image

Project Segment creation
https://www.loom.com/share/27ec8d4a2d8d4c24b443ac5d2b12231e?focus_title=1&muted=1&from_recorder=1

Feature specific segment creation
https://www.loom.com/share/8cc4d8e92ce84c459dfb6598ebb42acb

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 25, 2025 14:36
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team April 25, 2025 14:36
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 3:32pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2025 3:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 3:32pm

@Zaimwa9 Zaimwa9 marked this pull request as draft April 25, 2025 14:36
@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Apr 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5394 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5394 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5394 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5394 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5394 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5394 Finished ✅ Results ✅

@github-actions github-actions Bot added the feature New feature or request label Apr 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2025 •
edited
Loading

Uffizzi Preview deployment-63157 was deleted.

@Zaimwa9 Zaimwa9 changed the title feat: frontend-clone-segments feat: frontend-clone-segments 🔴 Blocked by #5393 Apr 25, 2025
Zaimwa9
Zaimwa9 commented Apr 28, 2025
View reviewed changes
Comment thread frontend/e2e/tests/segment-test.ts Outdated
@Zaimwa9 Zaimwa9 marked this pull request as ready for review April 28, 2025 10:30
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Apr 28, 2025
kyle-ssg
kyle-ssg reviewed Apr 29, 2025
View reviewed changes
Comment thread frontend/common/utils/calculateListPosition.ts
kyle-ssg
kyle-ssg reviewed Apr 29, 2025
View reviewed changes
Comment thread frontend/web/components/segments/SegmentRow/SegmentRow.tsx
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 1, 2025
@Zaimwa9 Zaimwa9 requested a review from kyle-ssg May 1, 2025 15:45
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 1, 2025
@Zaimwa9 Zaimwa9 requested a review from tiagoapolo May 12, 2025 08:58
tiagoapolo
tiagoapolo approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tiagoapolo tiagoapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reference the new components that are using react router in #5442?

@matthewelwell matthewelwell mentioned this pull request May 25, 2025
Closed
4 tasks
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 26, 2025
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels May 26, 2025
@Zaimwa9 Zaimwa9 merged commit 6801499 into main May 29, 2025
42 of 43 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/frontend-clone-segments branch May 29, 2025 08:39
@flagsmithdev flagsmithdev mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg

1 more reviewer

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tiagoapolo tiagoapolo

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zaimwa9 @tiagoapolo @kyle-ssg