Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
gagantrivedi
force-pushed
the
feat/release-pipeline
branch
6 times, most recently
from
e5fab00 to
6b14e39
Compare
gagantrivedi
force-pushed
the
feat/release-pipeline
branch
6 times, most recently
from
550f092 to
4909e38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
========================================
Coverage 97.76% 97.77%
========================================
Files 1245 1253 +8
Lines 44062 44233 +171
========================================
+ Hits 43076 43247 +171
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zaimwa9
reviewed
Jun 23, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Looks good to me overall, will need to add test and coverage
Zaimwa9
reviewed
Jun 24, 2025
gagantrivedi
force-pushed
the
feat/release-pipeline
branch
4 times, most recently
from
9a4242a to
7c4ef9f
Compare
for more information, see https://pre-commit.ci
gagantrivedi
force-pushed
the
feat/release-pipeline
branch
from
c773096 to
3be9ede
Compare
gagantrivedi
force-pushed
the
feat/release-pipeline
branch
2 times, most recently
from
b20e53b to
9fdd219
Compare
gagantrivedi
changed the title
Contributor
Docker builds report
|
Zaimwa9
approved these changes
Jul 1, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
LGTM and been tested over the different frontend reviews.
One UX comment (ordering) if possible to update in private
| release_pipelines_views = importlib.import_module("release_pipelines_logic.views") | ||
| projects_router.register( | ||
| r"release-pipelines", | ||
| release_pipelines_views.ReleasePipelineViewSet, |
Contributor
There was a problem hiding this comment.
My bad, I realized this morning. Right now they are ordered by ASC created at. It might make more sense to have the newest pipelines first in GET list if not too much effort
|
|
||
|
|
||
| class PipelineStage(models.Model): | ||
| name = models.CharField(max_length=255) |
Contributor
There was a problem hiding this comment.
@tiagoapolo, NIT detail for future versions but maybe in the frontend we could warn/block same stage names in a pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Related Epic: #5486
How did you test this code?
Add new unit test here and in the private repo