feat: Handle LaunchDarkly rate limiting#5501
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
khvn26
force-pushed
the
feat/handle-launch-darkly-rate-limiting
branch
from
da8c190 to
82ceeb5
Compare
Contributor
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5501 ⚙️ Updating now by workflow run 15307046164. What is Uffizzi? Learn more! |
github-actions
Bot
added
feature
github-actions
Bot
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5501 +/- ##
=======================================
Coverage 97.65% 97.66%
=======================================
Files 1237 1239 +2
Lines 43580 43677 +97
=======================================
+ Hits 42558 42657 +99
+ Misses 1022 1020 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
feature
github-actions
Bot
added
feature
Contributor
Docker builds report
|
github-actions
Bot
added
feature
khvn26
commented
May 29, 2025
| djangorestframework-dataclasses = "^1.3.1" | ||
| pyotp = "^2.9.0" | ||
| flagsmith-common = "^1.13.0" | ||
| flagsmith-common = { git = "https://github.com/flagsmith/flagsmith-common", branch = "feat/task-backoff" } |
Member
Author
There was a problem hiding this comment.
Redirect back to PyPI after Flagsmith/flagsmith-common#81 is merged and released.
khvn26
commented
May 29, 2025
| def _handle_giveup( | ||
| details: Details, | ||
| ) -> None: | ||
| exc: RequestException = details["exception"] # type: ignore[typeddict-item] |
Member
Author
There was a problem hiding this comment.
This type ignore is an annoying one, especially considering the (otherwise excellent) backoff library is not maintained anymore.
NB: consider switching all backoff usage to stamina.
github-actions
Bot
added
feature
Member
There was a problem hiding this comment.
We don't have to add TASK_BACKOFF_DEFAULT_DELAY_SECONDS used here?
Zaimwa9
reviewed
May 30, 2025
| exc: RequestException = details["exception"] # type: ignore[typeddict-item] | ||
|
|
||
| if retry_after := _get_retry_after(exc): | ||
| raise LaunchDarklyRateLimitError( |
Contributor
There was a problem hiding this comment.
It could be nice to log the project/org maybe if it's simple to access them here ?
github-actions
Bot
added
feature
Member
Author
@gagantrivedi Added in 445ebb8. |
gagantrivedi
approved these changes
May 30, 2025
github-actions
Bot
added
feature
github-actions
Bot
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Closes #5361.
This PR adds rate limiting handling for LaunchDarkly client.
If rate limiting persists after 5 tries, the whole import request is backed off using functionality added in Flagsmith/flagsmith-common#81.
How did you test this code?
Added a bunch of new unit tests.