Merged
Conversation
Zaimwa9
requested review from
gagantrivedi and
kyle-ssg
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
github-actions
bot
added
front-end
Contributor
Docker builds report
|
…/flagsmith into fix/hubspot-attribution-issues
Contributor
Author
|
Thanks for the detailed feedback.
Definitely, let me know if this feels clearer
That should be the case, more precisely there are 2 entrypoints:
Additionally, I added a basic retry with backoff in create_lead_form, without raising for now |
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
The code look a LOT cleaner now - so much easier to follow. I've added a few more comments, but I think that we're pretty close.
I've resolved all of the previous comments as well.
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
…t-attribution-issues
matthewelwell
approved these changes
Jun 20, 2025
Zaimwa9
commented
Jul 3, 2025
Comment on lines
22
to
31
| if ( | ||
| HubspotTracker.objects.filter(hubspot_cookie=hubspot_cookie) # type: ignore[misc] | ||
| .exclude(user=request.user) | ||
| .exclude(user=track_user) | ||
| .exists() | ||
| ): | ||
| logger.info( | ||
| f"HubspotTracker could not be created for user {request.user.id}" | ||
| f"HubspotTracker could not be created for user {track_user.id}" | ||
| f" due to cookie conflict with cookie {hubspot_cookie}" | ||
| ) | ||
| return |
Contributor
Author
There was a problem hiding this comment.
@matthewelwell , I think we can remove this guard and allow for multiple identical cookies (cf the user who created 3 accounts. We lost the info on the account we cared about)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
create_lead_formwith or without cookie) and savesHubspotLeadsa) If organisation was just created and exists in hubspot => get company data from hubspot, saves the
HubspotOrganisationobject with correct idb) if doesn't exist in hubspot for X reason => creates it and saves hubspot ID
How did you test this code?
Please describe.
Functionally:
Set
"ENABLE_HUBSPOT_LEAD_TRACKING": "True"andHUBSPOT_ACCESS_TOKENCreate user, organisation, invite users