Skip to content

fix: handle (ignore) unrecognised analytics data#5564

Merged
matthewelwell merged 3 commits intomainfrom
fix/ignore-unrecognised-features-in-analytics
Jun 17, 2025
Merged

fix: handle (ignore) unrecognised analytics data#5564
matthewelwell merged 3 commits intomainfrom
fix/ignore-unrecognised-features-in-analytics

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Update API logic to track analytics for any valid features in a payload, even if there are other features which are invalid.

How did you test this code?

Updated existing tests.

@matthewelwell matthewelwell requested a review from a team as a code owner June 11, 2025 15:08
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team June 11, 2025 15:08
@github-actions github-actions bot added the api Issue related to the REST API label Jun 11, 2025
…in-analytics

# Conflicts:
#	api/app_analytics/views.py
@github-actions github-actions bot added the fix label Jun 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5564 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5564 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5564 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5564 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5564 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5564 Finished ✅ Results

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 1:11pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 1:11pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 1:11pm

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (8ebf949) to head (0eb4dab).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5564      +/-   ##
==========================================
+ Coverage   97.69%   97.73%   +0.03%     
==========================================
  Files        1247     1255       +8     
  Lines       44249    44489     +240     
==========================================
+ Hits        43231    43482     +251     
+ Misses       1018     1007      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added fix and removed fix labels Jun 17, 2025
@matthewelwell matthewelwell merged commit a2164a6 into main Jun 17, 2025
29 checks passed
@matthewelwell matthewelwell deleted the fix/ignore-unrecognised-features-in-analytics branch June 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analytics endpoint should store valid analytics data even if some is invalid

2 participants