Skip to content

fix: use-query-from-workflow-list-change-request#5568

Merged
Zaimwa9 merged 2 commits intomainfrom
fix/scheduled-change-metrics-definition
Jun 13, 2025
Merged

fix: use-query-from-workflow-list-change-request#5568
Zaimwa9 merged 2 commits intomainfrom
fix/scheduled-change-metrics-definition

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Jun 12, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Scheduled changes calculation was solely relying on feature states while real use case is based on change requests (and depending on environment versioning).

Reworked the calculation by using the query used in flagsmith-workflows GET list-change-requests as to count exactly the records that would be shown in scheduled changes page

How did you test this code?

  • Created scheduled changes and verified the count
  • Reworked the tests

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 12, 2025 15:57
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for a team June 12, 2025 15:57
@vercel
Copy link
Copy Markdown

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2025 8:11am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2025 8:11am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2025 8:11am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jun 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 12, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5568 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5568 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5568 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5568 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5568 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (c1eed05) to head (90cfc8b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5568   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files        1247     1247           
  Lines       44249    44253    +4     
=======================================
+ Hits        43231    43235    +4     
  Misses       1018     1018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added fix and removed fix labels Jun 13, 2025
@Zaimwa9 Zaimwa9 merged commit 54131af into main Jun 13, 2025
30 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/scheduled-change-metrics-definition branch June 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants