feat: generate-a-auth-cookie-on-oauth-succesful-logins#5670
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
for more information, see https://pre-commit.ci
Contributor
Docker builds report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5670 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1253 1253
Lines 44242 44279 +37
=======================================
+ Hits 43256 43293 +37
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emyller
requested changes
Jun 30, 2025
Contributor
emyller
left a comment
There was a problem hiding this comment.
Solution looks good with a slight re-shaping. Also please add tests to cover the settings.COOKIE_AUTH_ENABLED case. Thanks!
…smith/flagsmith into feat/support-oauth-with-cookie-auth
…rt-oauth-with-cookie-auth
emyller
reviewed
Jul 2, 2025
emyller
reviewed
Jul 2, 2025
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
emyller
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Allow Google and Github OAuth with cookie login.
How did you test this code?