Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Contributor
Docker builds report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5798 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1257 1257
Lines 44617 44625 +8
=======================================
+ Hits 43643 43651 +8
Misses 974 974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
feature
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Nice to see that no tests needed to change for this!
khvn26
force-pushed
the
feat/context-values
branch
from
3b77929 to
e692a89
Compare
github-actions
bot
added
feature
matthewelwell
approved these changes
Jul 22, 2025
khvn26
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5674.
As part of this, I realised that using flagsmith-flag-engine ^6.0.0 together with the Flagsmith SDK is impossible, so had to publish flagsmith-flag-engine 5.4.3 with a backport of
get_identity_segments.docs/if required so people know about the feature!Changes
This bumps Flagsmith Engine to a version supporting Context values, enabling Context values evaluation in the Core API. Some code paths were updated to support the context object now expected by some of the Engine's internal-ish APIs.
How did you test this code?
Updated relevant tests. The evaluation itself was tested in the engine. This will be tested on staging as part of the integration testing, together with UI.