fix(cache_page): use vary on header with env api key#5800
Merged
gagantrivedi merged 2 commits intomainfrom Jul 22, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5800 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1257 1257
Lines 44586 44667 +81
=======================================
+ Hits 43612 43693 +81
Misses 974 974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
4 tasks
khvn26
reviewed
Jul 22, 2025
| FLAGSMITH_SIGNATURE_HEADER = "X-Flagsmith-Signature" | ||
|
|
||
| FLAGSMITH_UPDATED_AT_HEADER = "X-Flagsmith-Document-Updated-At" | ||
| SDK_ENVIRONMENT_KEY_HEADER = "X_ENVIRONMENT_KEY" |
Member
There was a problem hiding this comment.
nit: Annoying that we have to use different formats here. Maybe vary_on_headers(snake_case(SDK_ENVIRONMENT_KEY_HEADER).upper())) would be nicer, but maybe it's just my OCD-ish tendencies in play here.
khvn26
pushed a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Use SDK_ENVIRONMENT_KEY_HEADER as part of cache key to make sure different response is cached for different environments
Closes: #5726, #5001
How did you test this code?
Add Unit test