Skip to content

fix(Audit): Stop error noise when deleting segment overrides#6941

Merged
emyller merged 1 commit intomainfrom
fix/async-featuresegment-objectdoesnotexist
Mar 13, 2026
Merged

fix(Audit): Stop error noise when deleting segment overrides#6941
emyller merged 1 commit intomainfrom
fix/async-featuresegment-objectdoesnotexist

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Mar 13, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #6792

Fix FeatureSegment.DoesNotExist noise when deleting a segment override individually, or cascaded by deleting a segment. There's no need to reprocess tasks because the audit trail is not affected.

How did you test this code?

Reproducing the Sentry error in a new test.

@emyller emyller self-assigned this Mar 13, 2026
@emyller emyller requested a review from a team as a code owner March 13, 2026 02:28
@emyller emyller requested review from khvn26 and removed request for a team March 13, 2026 02:28
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Mar 13, 2026 2:55am
flagsmith-frontend-preview Ignored Ignored Preview Mar 13, 2026 2:55am
flagsmith-frontend-staging Ignored Ignored Preview Mar 13, 2026 2:55am

Request Review

@github-actions github-actions bot added api Issue related to the REST API fix labels Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6941 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6941 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6941 Finished ✅ Results

@emyller emyller changed the title fix(Segments): Fix audit trail when deleting overrides fix(Audit): Stop error noise when deleting segment overrides Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  51.6 seconds
commit  2991564
info  🔄 Run: #15284 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  50.1 seconds
commit  2991564
info  🔄 Run: #15284 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  54.4 seconds
commit  2991564
info  🔄 Run: #15284 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 9 seconds
commit  2991564
info  🔄 Run: #15284 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.3 seconds
commit  849b5b4
info  🔄 Run: #15285 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  29.4 seconds
commit  849b5b4
info  🔄 Run: #15285 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  11 seconds
commit  e2da62d
info  🔄 Run: #15287 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  46 seconds
commit  e2da62d
info  🔄 Run: #15287 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  35.7 seconds
commit  e2da62d
info  🔄 Run: #15287 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  54 seconds
commit  e2da62d
info  🔄 Run: #15287 (attempt 1)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (1c67f96) to head (e2da62d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6941   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files        1335     1335           
  Lines       49717    49745   +28     
=======================================
+ Hits        48879    48907   +28     
  Misses        838      838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the fix/async-featuresegment-objectdoesnotexist branch from 849b5b4 to e2da62d Compare March 13, 2026 02:55
@github-actions github-actions bot added fix and removed fix labels Mar 13, 2026
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me 👍

@emyller emyller merged commit c2bddaf into main Mar 13, 2026
33 checks passed
@emyller emyller deleted the fix/async-featuresegment-objectdoesnotexist branch March 13, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureSegment.DoesNotExist in tasks.create_audit_log_from_historical_record

2 participants