Skip to content

fix: make Feature.type writable on create #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gagantrivedi merged 2 commits into from
Mar 19, 2026
Merged

fix: make Feature.type writable on create #6986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc0d87
fix: make Feature.type writable on create
gagantrivedi Mar 19, 2026
0ebd98f
fix: replace deprecated "FLAG" type in tests with STANDARD
gagantrivedi Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/features/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ class Meta:
"created_date",
"uuid",
"project",
"type",
)

def to_internal_value(self, data): # type: ignore[no-untyped-def]
Expand Down
28 changes: 20 additions & 8 deletions api/tests/unit/features/test_unit_features_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ def test_create_feature_only_triggers_write_to_dynamodb_once_per_environment(
project.save()

url = reverse("api-v1:projects:project-features-list", args=[project.id])
data = {"name": "Test feature flag", "type": "FLAG", "project": project.id}
data = {"name": "Test feature flag", "type": STANDARD, "project": project.id}

mock_dynamo_environment_wrapper.is_enabled = True
mock_dynamo_environment_wrapper.reset_mock()
Expand Down Expand Up @@ -1748,7 +1748,7 @@ def test_create_feature_returns_201_if_name_matches_regex(
feature_name = "valid_feature_name"

url = reverse("api-v1:projects:project-features-list", args=[project.id])
data = {"name": feature_name, "type": "FLAG", "project": project.id}
data = {"name": feature_name, "type": STANDARD, "project": project.id}

# When
response = admin_client_new.post(url, data=data)
Expand All @@ -1766,7 +1766,7 @@ def test_create_feature_returns_400_if_name_does_not_matches_regex(
feature_name = "not_a_valid_feature_name"

url = reverse("api-v1:projects:project-features-list", args=[project.id])
data = {"name": feature_name, "type": "FLAG", "project": project.id}
data = {"name": feature_name, "type": STANDARD, "project": project.id}

# When
response = admin_client_new.post(url, data=data)
Expand All @@ -1784,7 +1784,7 @@ def test_audit_log_created_when_feature_created(
) -> None:
# Given
url = reverse("api-v1:projects:project-features-list", args=[project.id])
data = {"name": "Test feature flag", "type": "FLAG", "project": project.id}
data = {"name": "Test feature flag", "type": STANDARD, "project": project.id}

# When
response = admin_client_new.post(url, data=data)
Expand Down Expand Up @@ -4490,22 +4490,34 @@ def test_list_features__edge_v2_project__makes_one_dynamo_query(
assert mock_table.query.call_count == 1


def test_create_feature__type_provided__ignores_type_and_defaults_to_standard(
@pytest.mark.parametrize(
"feature_type, expected_status",
[
(STANDARD, status.HTTP_201_CREATED),
(MULTIVARIATE, status.HTTP_201_CREATED),
("boolean", status.HTTP_400_BAD_REQUEST),
("FLAG", status.HTTP_400_BAD_REQUEST),
],
)
def test_create_feature__type_provided__validates_and_sets_type(
admin_client_new: APIClient,
project: Project,
feature_type: str,
expected_status: int,
) -> None:
# Given
url = reverse("api-v1:projects:project-features-list", args=[project.id])
data = {"name": "test_feature_type_readonly", "type": "boolean"}
data = {"name": f"test_feature_{feature_type}", "type": feature_type}

# When
response = admin_client_new.post(
url, data=json.dumps(data), content_type="application/json"
)

# Then
assert response.status_code == status.HTTP_201_CREATED
assert response.json()["type"] == STANDARD
assert response.status_code == expected_status
if expected_status == status.HTTP_201_CREATED:
assert response.json()["type"] == feature_type


def test_create_feature__multivariate_options_provided__sets_type_to_multivariate(
Expand Down
Loading