Skip to content

refactor: migrate get features + remove datadog widget#7093

Open
kyle-ssg wants to merge 5 commits intomainfrom
refactor/migrate-get-features
Open

refactor: migrate get features + remove datadog widget#7093
kyle-ssg wants to merge 5 commits intomainfrom
refactor/migrate-get-features

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Apr 1, 2026 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

How did you test this code?

  • Tested import / export features
  • E2E

@kyle-ssg kyle-ssg requested a review from a team as a code owner April 1, 2026 11:43
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team April 1, 2026 11:43
claude[bot]
claude bot reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@kyle-ssg kyle-ssg changed the title refactore: migrate get features + remove datadog widget refactore migrate get features + remove datadog widget Apr 1, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 8, 2026 8:43am
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 8, 2026 8:43am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 8, 2026 8:43am

Request Review

@kyle-ssg kyle-ssg changed the title refactore migrate get features + remove datadog widget refactor: migrate get features + remove datadog widget Apr 1, 2026
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-7093 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7093 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7093 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  41.5 seconds
commit  523feff
info  🔄 Run: #15606 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.4 seconds
commit  523feff
info  🔄 Run: #15606 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  57.6 seconds
commit  523feff
info  🔄 Run: #15606 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  43.6 seconds
commit  523feff
info  🔄 Run: #15606 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  41.7 seconds
commit  aac784a
info  🔄 Run: #15857 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  37.9 seconds
commit  94b7266
info  🔄 Run: #15856 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.8 seconds
commit  aac784a
info  🔄 Run: #15857 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  30.4 seconds
commit  94b7266
info  🔄 Run: #15856 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  49.1 seconds
commit  aac784a
info  🔄 Run: #15857 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  55.6 seconds
commit  94b7266
info  🔄 Run: #15856 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 6 seconds
commit  aac784a
info  🔄 Run: #15857 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  25.3 seconds
commit  e34572b
info  🔄 Run: #15860 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  94b7266
info  🔄 Run: #15856 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  44.8 seconds
commit  e34572b
info  🔄 Run: #15860 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  50.4 seconds
commit  e34572b
info  🔄 Run: #15860 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.7 seconds
commit  e34572b
info  🔄 Run: #15860 (attempt 1)

talissoncosta
talissoncosta reviewed Apr 1, 2026
View reviewed changes
frontend/web/components/pages/UserPage.tsx

const { data: featureListData, isFetching: isLoadingFeatures } =
useGetFeatureListQuery(
apiParams ? { ...apiParams, identity: id } : ({} as any),
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since skip already prevents the query from firing, is the {} as any fallback needed here?

Copy link
Copy Markdown
Member Author

@kyle-ssg kyle-ssg Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent type errors yeah, It was Claude and I did think it was weird at first but its actually a nice safe way to have the spread params and also specify query params without type errors.

talissoncosta
talissoncosta reviewed Apr 1, 2026
View reviewed changes
frontend/web/components/import-export/FeatureImport.tsx
setCurrentFeatureStates(FeatureListStore.getEnvironmentFlags())
}
FeatureListStore.on('change', callback)
const { getEnvironmentIdFromKey, isLoading: _isLoadingEnvs } =
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed FeatureExport.tsx uses isLoadingEnvs in its loading state but FeatureImport.tsx doesn't — is that intentional?

Copy link
Copy Markdown
Member Author

@kyle-ssg kyle-ssg Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah import doesnt need to wait for envs

talissoncosta
talissoncosta previously approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments, not blockers. Thanks for handling that @kyle-ssg

@kyle-ssg
Merge branch 'main' into refactor/migrate-get-features
479f45b 
# Conflicts:
#	frontend/package-lock.json
@kyle-ssg kyle-ssg requested a review from talissoncosta April 8, 2026 08:36
@github-actions github-actions bot added refactor and removed refactor labels Apr 8, 2026
@github-actions github-actions bot added refactor and removed refactor labels Apr 8, 2026
@talissoncosta
Copy link
Copy Markdown
Contributor

talissoncosta commented Apr 8, 2026

Is it good to review ? @kyle-ssg can you please rebase it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@talissoncosta talissoncosta Awaiting requested review from talissoncosta

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate retrieving features to RTK

2 participants

@kyle-ssg @talissoncosta