Skip to content

ci: skip-private-tests-and-comments-conditionally-for-oss-contributions#7189

Merged
Zaimwa9 merged 2 commits intomainfrom
ci/update-pull-request-workflow-for-oss-contributions
Apr 9, 2026
Merged

ci: skip-private-tests-and-comments-conditionally-for-oss-contributions#7189
Zaimwa9 merged 2 commits intomainfrom
ci/update-pull-request-workflow-for-oss-contributions

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 9, 2026 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Fork PRs receive a read-only GITHUB_TOKEN and have no access to repo secrets, causing private package tests to fail on checkout and E2E jobs to fail when posting PR comments despite tests passing.

  • Skip private packages tests for fork PRs (secrets unavailable)
  • continue-on-error sticky comments posting E2E results

How did you test this code?

  • not yet: CI

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 9, 2026 08:55
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team April 9, 2026 08:55
claude[bot]
claude bot reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 9, 2026 9:01am
flagsmith-frontend-preview Ignored Ignored Preview Apr 9, 2026 9:01am
flagsmith-frontend-staging Ignored Ignored Preview Apr 9, 2026 9:01am

Request Review

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7189 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7189 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7189 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7189 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7189 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7189 Finished ✅ Results ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (de527ae) to head (712781e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7189   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files        1348     1348           
  Lines       50666    50666           
=======================================
  Hits        49834    49834           
  Misses        832      832

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  24.6 seconds
commit  2cd8acd
info  🔄 Run: #15918 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  27.9 seconds
commit  2cd8acd
info  🔄 Run: #15918 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 2 seconds
commit  2cd8acd
info  🔄 Run: #15918 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  56.8 seconds
commit  2cd8acd
info  🔄 Run: #15918 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.9 seconds
commit  712781e
info  🔄 Run: #15919 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  11.5 seconds
commit  712781e
info  🔄 Run: #15919 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47.9 seconds
commit  712781e
info  🔄 Run: #15919 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  712781e
info  🔄 Run: #15919 (attempt 1)

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

germangarces
germangarces approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@germangarces germangarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zaimwa9 Zaimwa9 merged commit 9e3edac into main Apr 9, 2026
34 checks passed
@Zaimwa9 Zaimwa9 deleted the ci/update-pull-request-workflow-for-oss-contributions branch April 9, 2026 10:32
@flagsmithdev flagsmithdev mentioned this pull request Apr 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@germangarces germangarces germangarces approved these changes

@talissoncosta talissoncosta Awaiting requested review from talissoncosta talissoncosta is a code owner automatically assigned from Flagsmith/flagsmith-engineering

Assignees

No one assigned

Labels

ci-cd Build, test and deployment related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zaimwa9 @germangarces