Conversation
Remove dead CSS selectors, unused mixin files, and entirely unused component styles identified by cross-referencing class names against the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add `npm run test:visual:baselines` which checks out main, runs E2E with VISUAL_REGRESSION=1 to capture baseline screenshots locally, then switches back to the current branch. Both runs use the same machine so diffs reflect actual style changes, not platform rendering differences. Also adds `npm run test:visual:baselines:ci` to download baselines from CI artifacts, and `/visual-regression` Claude Code command. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The roles test was capturing the users-and-permissions snapshot while a toast from createFeature was still visible, causing flaky visual regression diffs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove images, dropdown, button-group, nav, navbar, breadcrumb, close, and spinners Bootstrap imports. The codebase uses custom components for all of these (InlineModal, ButtonDropdown, Loader, etc). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove ~330 lines from _spacing-utils.scss (duplicated BS5 spacing) Keep only ml-*/mr-*/pl-*/pr-* (BS4 naming compat), mt-n1, px-md-5 - Remove 6 duplicate utility classes from _utils.scss that BS5 generates - Rename custom classes to BS5 equivalents in components: float-right -> float-end, relative -> position-relative, text-left -> text-start, align-start -> align-items-start, pointer-events-none -> pe-none, left-0 -> start-0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression16 screenshots compared. See report for details. |
|
Added you as a reviewer manually @talissoncosta as I wasn't sure whether some of your work compliments component testing this? |
| <Flex className='mb-2' style={{ position: 'relative' }}> | ||
| <Flex | ||
| className='mb-2' | ||
| style={{ position: 'position-relative' }} |
There was a problem hiding this comment.
We should use position-relative as a class instead of inline style
|
|
||
| {sorting && ( | ||
| <Row className='mr-3 relative'> | ||
| <Row className='mr-3position-relative'> |
There was a problem hiding this comment.
Missing space between classes.
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
Nice cleanup. @kyle-ssg. Thanks for that
Flagged two small issues. I checked the preview and couldn't spot visual regressions from either, but they're still broken classes that should be fixed.
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
How did you test this code?
Visual regression tests show 0 regressions