Skip to content

feat: removed-gram-implementation#7378

Merged
Zaimwa9 merged 3 commits intomainfrom
feat/remove-gram-elements
Apr 30, 2026
Merged

feat: removed-gram-implementation#7378
Zaimwa9 merged 3 commits intomainfrom
feat/remove-gram-elements

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 30, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Cleaned up Gram Elements implementation

How did you test this code?

@Zaimwa9 Zaimwa9 requested review from a team as code owners April 30, 2026 09:32
@Zaimwa9 Zaimwa9 requested review from khvn26 and kyle-ssg and removed request for a team April 30, 2026 09:32
claude[bot]
claude Bot reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 30, 2026 2:19pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 30, 2026 2:19pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 30, 2026 2:19pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API feature New feature or request labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7378 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7378 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7378 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-7378 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7378 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7378 Finished ✅ Results ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.44%. Comparing base (413c9b8) to head (82b340e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7378   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files        1398     1398           
  Lines       52628    52628           
=======================================
  Hits        51808    51808           
  Misses        820      820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  8.8 seconds
commit  82b340e
info  🔄 Run: #16457 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  49.8 seconds
commit  82b340e
info  🔄 Run: #16457 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.2 seconds
commit  82b340e
info  🔄 Run: #16457 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  82b340e
info  🔄 Run: #16457 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  50.5 seconds
commit  1b1e911
info  🔄 Run: #16458 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  47.8 seconds
commit  1b1e911
info  🔄 Run: #16458 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 4 seconds
commit  1b1e911
info  🔄 Run: #16458 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  57.4 seconds
commit  1b1e911
info  📦 Artifacts: View test results and HTML report
🔄 Run: #16458 (attempt 1)

Failed tests

firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  53.7 seconds
commit  1b1e911
info  🔄 Run: #16458 (attempt 2)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  38.9 seconds
commit  d9ba7fb
info  🔄 Run: #16475 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  11.1 seconds
commit  d9ba7fb
info  🔄 Run: #16475 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.6 seconds
commit  d9ba7fb
info  🔄 Run: #16475 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  57.1 seconds
commit  d9ba7fb
info  🔄 Run: #16475 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Apr 30, 2026
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for khvn26 and kyle-ssg April 30, 2026 12:08
talissoncosta
talissoncosta reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some questions before approving it.

Just checking have you ran nom install after removing the packages from package.json ?

Also, can you clarify why we should have two identical gram.json on the project?

@Zaimwa9
Copy link
Copy Markdown
Contributor Author

Zaimwa9 commented Apr 30, 2026

Good call on both. Gram.json was a miss after removing it by mistake

@Zaimwa9 Zaimwa9 requested a review from talissoncosta April 30, 2026 14:18
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Apr 30, 2026
@Zaimwa9 Zaimwa9 merged commit f9be78d into main Apr 30, 2026
29 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/remove-gram-elements branch April 30, 2026 14:32
@flagsmithdev flagsmithdev mentioned this pull request Apr 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@talissoncosta talissoncosta talissoncosta approved these changes

Assignees

No one assigned

Labels

api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zaimwa9 @talissoncosta