Skip to content

Commit b3bd86d

Browse files
authored
Merge pull request #71 from Flared/mahinse/fix_blind_mode
Proper color for dropdown caret in light mode + make count + caret clickable
2 parents 077f4da + 2cfc3aa commit b3bd86d

2 files changed

Lines changed: 34 additions & 16 deletions

File tree

packages/react-components/src/components/SourceTypeCategoryOption.css

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,26 +22,35 @@
2222
flex-direction: row;
2323
}
2424

25+
.source-types-category-filler {
26+
flex: 1;
27+
}
28+
29+
.source-types-category-count-container {
30+
display: flex;
31+
flex-direction: row;
32+
cursor: pointer;
33+
}
34+
2535
.source-types-category-count {
36+
width: 1rem;
2637
user-select: none;
2738
color: var(--secondary-text-color);
28-
flex: 1;
29-
text-align: end;
39+
text-align: center;
3040
}
3141

3242
.source-types-category {
3343
width: 1rem;
3444
height: 1rem;
3545
margin-left: 0.5rem;
36-
cursor: pointer;
3746
align-self: center;
3847
}
3948

4049
.source-types-category > span {
4150
display: inline-table;
4251
width: 0.5rem;
4352
height: 0.5rem;
44-
border: solid white;
53+
border: solid var(--text-color);
4554
border-width: 0 0 0.125rem 0.125rem;
4655
}
4756

packages/react-components/src/components/SourceTypeCategoryOption.tsx

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,31 @@ const SourceTypeCategoryOption: FC<{
3636
onCheckChange={(checked): void => onCategoryCheckChange(checked)}
3737
/>
3838

39-
<span
40-
hidden={sourceTypeCategory.types.length <= 1}
41-
className="source-types-category-count"
42-
>
43-
{selectedCategoryCount}
44-
</span>
4539
<div
4640
hidden={sourceTypeCategory.types.length <= 1}
47-
className={`source-types-category ${
48-
isExpanded
49-
? 'source-types-category-collapse'
50-
: 'source-types-category-expand'
51-
}`}
41+
className="source-types-category-filler"
42+
/>
43+
44+
<div
45+
className="source-types-category-count-container"
5246
onClick={(): void => setExpanded(!isExpanded)}
5347
>
54-
<span />
48+
<div
49+
hidden={sourceTypeCategory.types.length <= 1}
50+
className="source-types-category-count"
51+
>
52+
{selectedCategoryCount}
53+
</div>
54+
<div
55+
hidden={sourceTypeCategory.types.length <= 1}
56+
className={`source-types-category ${
57+
isExpanded
58+
? 'source-types-category-collapse'
59+
: 'source-types-category-expand'
60+
}`}
61+
>
62+
<span />
63+
</div>
5564
</div>
5665
</div>
5766
<div className="source-types-children-container" hidden={!isExpanded}>

0 commit comments

Comments
 (0)