SHM-jemalloc borrow_object(): odd-alignment acceptance. / Impl notes: Unit-test coverage of SHM-classic and SHM-jemalloc borrow_object() (et al) hardening; and basic construct()/lend_object()/borrow_object() cycle end-to-end. / Unit-test bug fix (existing test failed to properly cleanup => caused trouble in subsequent new tests).#67
Merged
SHM-jemalloc borrow_object(): odd-alignment acceptance. / Impl notes: Unit-test coverage of SHM-classic and SHM-jemalloc borrow_object() (et al) hardening; and basic construct()/lend_object()/borrow_object() cycle end-to-end. / Unit-test bug fix (existing test failed to properly cleanup => caused trouble in subsequent new tests).#67
borrow_object(): odd-alignment acceptance. / Impl notes: Unit-test coverage of SHM-classic and SHM-jemalloc borrow_object() (et al) hardening; and basic construct()/lend_object()/borrow_object() cycle end-to-end. / Unit-test bug fix (existing test failed to properly cleanup => caused trouble in subsequent new tests).#67Conversation
…defensive about strange alignment of the SHM-handle blob.
…ow_object() x 4 and nearby.
…ome of its resources from a SHM-jemalloc singleton. (In upcoming release this is smoothed out more generally, but for now this fix prevents issues in a new test being added.
konarlio
approved these changes
May 5, 2026
Contributor
Author
|
Thanks, @konarlio! |
ygoldfeld
added a commit
to Flow-IPC/ipc
that referenced
this pull request
May 5, 2026
…d to documentation for `main` branch. / Pulling in submodules. (PRs Flow-IPC/flow#114 / Flow-IPC/ipc_transport_structured#35 / Flow-IPC/ipc_shm#32 / Flow-IPC/ipc_shm_arena_lend#67 / Flow-IPC/ipc_session#34 / Flow-IPC/ipc_core#42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To code reviewer