Skip to content

SHM-jemalloc borrow_object(): odd-alignment acceptance. / Impl notes: Unit-test coverage of SHM-classic and SHM-jemalloc borrow_object() (et al) hardening; and basic construct()/lend_object()/borrow_object() cycle end-to-end. / Unit-test bug fix (existing test failed to properly cleanup => caused trouble in subsequent new tests). #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ygoldfeld merged 6 commits into from
May 5, 2026
Merged

SHM-jemalloc borrow_object(): odd-alignment acceptance. / Impl notes: Unit-test coverage of SHM-classic and SHM-jemalloc borrow_object() (et al) hardening; and basic construct()/lend_object()/borrow_object() cycle end-to-end. / Unit-test bug fix (existing test failed to properly cleanup => caused trouble in subsequent new tests). #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1dbe1be
In `ipc::shm::arena_lend::jemalloc::Shm_session::borrow_object()` be …
ygoldfeld Apr 22, 2026
ad98c01
(cont) Unit tests for the ipc_shm[_arena_lend] changes hardening borr…
ygoldfeld Apr 23, 2026
568e9a3
(cont)
ygoldfeld Apr 23, 2026
2ba7e82
(cont) (debug)
ygoldfeld Apr 23, 2026
a60a451
Test suite: Fixing bug in an existing test which failed to clean-up s…
ygoldfeld Apr 23, 2026
459323f
(cont) (debug -- undo)
ygoldfeld Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/ipc/session/standalone/shm/arena_lend/jemalloc/shm_session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "ipc/session/standalone/shm/arena_lend/borrower_shm_pool_collection_repository.hpp"
#include "ipc/shm/arena_lend/jemalloc/ipc_arena.hpp"
#include "ipc/transport/struc/channel.hpp"
#include <cstring>

using ipc::shm::arena_lend::jemalloc::Ipc_arena;

Expand Down Expand Up @@ -346,11 +347,14 @@ bool Shm_session::deserialize_handle(const Blob& blob,
return false;
}

const uint8_t* blob_ptr = blob.const_data();
const auto object_handle = reinterpret_cast<const Shm_object_handle*>(blob_ptr);
collection_id = object_handle->m_collection_id;
shm_pool_id = object_handle->m_pool_id;
pool_offset = object_handle->m_pool_offset;
/* memcpy() it out of there: the source address may not be aligned. (In many APIs such things are assumed as a
* matter of course, but as `blob` may be IPCed-over to us via any technique, we're being
* extra defensive.) */
Shm_object_handle object_handle;
std::memcpy(&object_handle, blob.const_data(), sizeof(object_handle));
collection_id = object_handle.m_collection_id;
shm_pool_id = object_handle.m_pool_id;
pool_offset = object_handle.m_pool_offset;

return true;
}
Expand Down
6 changes: 6 additions & 0 deletions src/ipc/session/standalone/shm/arena_lend/jemalloc/test/shm_session_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ class Shm_session_test :
Borrower_shm_pool_collection_repository_singleton::get_instance().set_logger(get_logger());
}

~Shm_session_test() override
{
// Must remember to remove our stuff from singleton so as to not mess over subsequent tests.
Borrower_shm_pool_collection_repository_singleton::get_instance().set_logger(nullptr);
}

/**
* Retrieves the logger used in log messages, especially utilized with macros.
*
Expand Down
Loading