Add SublimeProjectLauncher plugin#496
Conversation
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Add SublimeProjectLauncher plugin |
cibere
left a comment
cibere
left a comment
There was a problem hiding this comment.
The metadata for your plugin here is different than the metadata in your plugin's plugin.json file.
For info about what should be included in your plugin's file in this repository, see the plugin submission instructions
For info about what should be included in your plugin's plugin.json file, see the docs on the plugin.json file
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "ID": "a7b9c10f-df98-42d7-b86f-6589d62f971d", | |||
| "Name": "Sublime Project Launcher", | |||
There was a problem hiding this comment.
The name here does not match the name in the filename.
Spaces in the filename are allowed, so renaming the file to Sublime Project Launcher-a7b9c10f-df98-42d7-b86f-6589d62f971d.json is a valid solution
| "ExecuteFileName": "main.py", | ||
| "Keyword": "sp", | ||
| "Website": "https://github.com/Rahulrgd/SublimeProjectLauncher", | ||
| "UrlDownload": "https://github.com/Rahulrgd/SublimeProjectLauncher/releases/latest", |
There was a problem hiding this comment.
This is not a download url that will work with our system. I checked out your repo, and it doesn't seem like you have a publishing workflow in place. We require all plugins on the manifest to use an automated github workflow to build the plugin and attach it to a github release. So, please see the docs on the github workflow and add it accordingly. Once you're done with that, the direct url to the artifact on the release is the url that should go here.
Here is an example of a valid download url: https://github.com/mjtimblin/Flow.Launcher.Plugin.AwsToolkit/releases/download/v1.0.3/Flow.Launcher.Plugin.AwsToolkit.zip
| "Author": "Rahul Gupta", | ||
| "Version": "1.0", | ||
| "Language": "python", | ||
| "ExecuteFileName": "main.py", |
There was a problem hiding this comment.
This key is exclusive to you're plugin's plugin.json file, and should not be provided here. See the plugin submission instructions for info about which keys you are supposed to provide here.
| "Version": "1.0", | ||
| "Language": "python", | ||
| "ExecuteFileName": "main.py", | ||
| "Keyword": "sp", |
There was a problem hiding this comment.
This key is exclusive to you're plugin's plugin.json file, and should not be provided here. See the plugin submission instructions for info about which keys you are supposed to provide here.
|
Another thing to mention: We try to limit the about of duplicate plugins, and encourage developers to collaborate on similar plugins. The RecentProjectsOpen plugin seems to have the same functionality as this plugin, and though it supports numerous code editors, sublime isn't one of them. Since both plugins are written in python, I would suggest migrating from creating this plugin to contributing to the RecentProjectsOpen plugin by implementing support for sublime. |
|
You seem to have fixed most things, however your release artifact seems to have been uploaded manually, and your publish workflow seems to have failed. Please fix your workflow and have the workflow upload the artifact. Additionally, do you mind giving a reason as to why you have chosen to progress with the creation of this plugin instead of contributing to the RecentProjectsOpen plugin?
|
|
Hi, you haven't provided a response in this PR for nine months, so as part of plugin PR clean-up we are closing this PR. If you would still like to add your plugin to the Flow Plugin store please address the issues raised above and create a new PR. Thank you. |
5 participants
No description provided.