Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
Comment thread
psycodess marked this conversation as resolved.
"ID": "f38c9470-7d31-401e-88ca-06c964bb3fc3",
"ActionKeyword": "hz",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove unsupported ActionKeyword from manifest

This repository only permits the fields listed in necessary_fields or optional_fields in ci/src/_utils.py, and ActionKeyword is not one of them. With this new file present, python -m pytest ci/src/validator.py -q fails in test_optional_fields for this manifest, so the submission cannot pass CI until this key is removed.

Useful? React with 👍 / 👎.

"Name": "Monitor Refresh Rate Changer",
"Description": "Change your monitor refresh rate easily from Flow Launcher",
"Author": "Musfikur Rhaman Sifat",
"Version": "1.0.0",
"Language": "python",
"Website": "https://github.com/psycodess/hz-plugin",
"IcoPath": "https://cdn.jsdelivr.net/gh/psycodess/hz-plugin@main/Images/app.png",
"UrlDownload": "https://github.com/psycodess/hz-plugin/releases/download/v1.0.0/hz-plugin.zip",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point UrlDownload at an existing release asset

For this new plugin, the manifest advertises v1.0.0, but the upstream psycodess/hz-plugin repository currently only exposes v0.2.0 and v0.1.0-alpha tags/releases, so there is no v1.0.0 release asset at this path. Flow will try to download exactly this UrlDownload during store installation, causing installs to fail until it points at a published GitHub release ZIP or that release is created.

Useful? React with 👍 / 👎.

"UrlSourceCode": "https://github.com/psycodess/hz-plugin"
}