Add forceShown param to ShowMsg and refactor notifications

Added forceShown to ShowMsg in IPublicAPI and updated PublicAPIInstance to support forced notifications. Error messages now always show regardless of user settings. Simplified ShowMsgWithButton to always display. Changed _saveSettingsLock to Lock type and made minor formatting improvements.

Author: Jack251970

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

@@ -136,6 +136,16 @@ public interface IPublicAPI
         /// <param name="useMainWindowAsOwner">when true will use main windows as the owner</param>
         void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true);
 
+        /// <summary>
+        /// Show message box
+        /// </summary>
+        /// <param name="title">Message title</param>
+        /// <param name="subTitle">Message subtitle</param>
+        /// <param name="iconPath">Message icon path (relative path to your plugin folder)</param>
+        /// <param name="useMainWindowAsOwner">when true will use main windows as the owner</param>
+        /// <param name="forceShown">when true will force the message to be shown regardless of user settings of `Show more notifications`</param>
+        void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true, bool forceShown = false);
+
         /// <summary>
         /// Show message box with button
         /// </summary>
@@ -162,7 +172,6 @@ public interface IPublicAPI
         /// </summary>
         void OpenSettingDialog();
 
-
         /// <summary>
         /// Open plugin setting window for a specific plugin.
         /// Reuses the existing window when that plugin's settings window is already open.

Flow.Launcher/PublicAPIInstance.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.Specialized;
@@ -53,7 +53,7 @@ public class PublicAPIInstance : IPublicAPI, IRemovable
         private Updater _updater;
         private Updater Updater => _updater ??= Ioc.Default.GetRequiredService<Updater>();
 
-        private readonly object _saveSettingsLock = new();
+        private readonly Lock _saveSettingsLock = new();
 
         #region Constructor
 
@@ -119,17 +119,20 @@ public void SaveAppAllSettings()
         public Task ReloadAllPluginData() => PluginManager.ReloadDataAsync();
 
         public void ShowMsgError(string title, string subTitle = "") =>
-            ShowMsg(title, subTitle, Constant.ErrorIcon, true);
+            ShowMsg(title, subTitle, Constant.ErrorIcon, forceShown:true);
 
         public void ShowMsgErrorWithButton(string title, string buttonText, Action buttonAction, string subTitle = "") =>
-            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, Constant.ErrorIcon, true);
+            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, Constant.ErrorIcon);
 
         public void ShowMsg(string title, string subTitle = "", string iconPath = "") =>
-            ShowMsg(title, subTitle, iconPath, true);
+            ShowMsg(title, subTitle, iconPath);
 
-        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true)
+        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true) =>
+            ShowMsg(title, subTitle, iconPath, useMainWindowAsOwner:useMainWindowAsOwner);
+
+        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true, bool forceShown = false)
         {
-            if (!_settings.EnableSuccessNotification &&
+            if (!forceShown && !_settings.EnableSuccessNotification &&
                 !string.Equals(iconPath, Constant.ErrorIcon, StringComparison.OrdinalIgnoreCase))
             {
                 return;
@@ -139,16 +142,10 @@ public void ShowMsg(string title, string subTitle, string iconPath, bool useMain
         }
 
         public void ShowMsgWithButton(string title, string buttonText, Action buttonAction, string subTitle = "", string iconPath = "") =>
-            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, iconPath, true);
+            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, iconPath);
 
         public void ShowMsgWithButton(string title, string buttonText, Action buttonAction, string subTitle, string iconPath, bool useMainWindowAsOwner = true)
-        {
-            if (!_settings.EnableSuccessNotification &&
-                !string.Equals(iconPath, Constant.ErrorIcon, StringComparison.OrdinalIgnoreCase))
-            {
-                return;
-            }
-
+        { 
             Notification.ShowWithButton(title, buttonText, buttonAction, subTitle, iconPath);
         }