Skip to content

Fix incorrect text highlighting when using pinyin queries #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VictoriousRaptor merged 6 commits into from
Dec 9, 2025
Merged

Fix incorrect text highlighting when using pinyin queries #4151

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d9de4b
Fix index lookup for boundary
VictoriousRaptor Dec 7, 2025
b869eb8
Avoid adding unnecessary space and improve unit test
VictoriousRaptor Dec 7, 2025
a7c67bb
Fix incorrect index marker
VictoriousRaptor Dec 7, 2025
769179d
Fix test case
VictoriousRaptor Dec 7, 2025
42e04d4
Cover all positions in unit test
VictoriousRaptor Dec 7, 2025
b6339d3
Fix compile error introduced by coderabbit
VictoriousRaptor Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Flow.Launcher.Infrastructure/TranslationMapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void AddNewIndex(int translatedIndex, int length)
public int MapToOriginalIndex(int translatedIndex)
{
var searchResult = _originalToTranslated.BinarySearch(translatedIndex);
return searchResult >= 0 ? searchResult : ~searchResult;
return searchResult >= 0 ? searchResult + 1 : ~searchResult;
Comment thread
Jack251970 marked this conversation as resolved.
}

public void EndConstruct()
Expand Down
Loading