Skip to content

Fix Quick Access Links of type File ignoring custom name in search results#4352

Closed
Copilot wants to merge 2 commits into
devfrom
copilot/fix-quick-access-links-names
Closed

Fix Quick Access Links of type File ignoring custom name in search results#4352
Copilot wants to merge 2 commits into
devfrom
copilot/fix-quick-access-links-names

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 13, 2026

  • Modify ResultManager.CreateFileResult to accept an optional custom name parameter
  • Update QuickAccess.cs to pass l.Name when creating File type results (both AccessLinkListMatched and AccessLinkListAll)
  • Run code review (no comments)
  • Run CodeQL security scan (no alerts)
Original prompt

This section details on the original issue you should resolve

<issue_title>dev: renamed file type Quick Access Links do not display the new names</issue_title>
<issue_description>### Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

  • I am using the prerelease version of Flow Launcher.

Problem Description

Dev branch, renamed Quick Access Links file type does not reflect their new names.

To Reproduce

  1. Rename file type quick access link via settings
  2. Open search window, name is still the same using original filename
  3. Ctrl + R to requery couple of times, name still using original filename

Screenshots

No response

Flow Launcher Version

1.20.1.x

Windows Build Number

Win 11

Error Log

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

@Jack251970 I cannot reproduce that with pre-release version v2.0.0.13812. Could you please check if this is still reproduceable? @Jack251970 Possibly handled by #3593 @Jack251970 @AlanEdd Hi, does this issue still exist in 2.1.1? @Jack251970 > Hi there, yes still exists. > > Image > > Image

So could you please tell me what the correct behavior should be?</comment_new>


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.


Summary by cubic

Quick Access file links now show the user-defined name instead of the filename in search. Fixes #3772.

  • Summary of changes
    • Changed: ResultManager.CreateFileResult accepts an optional name and uses it for the result title; QuickAccess passes l.Name for file results in both AccessLinkListMatched and AccessLinkListAll.
    • Added: Fallback to Path.GetFileName(filePath) when name is null.
    • Removed: No existing logic removed.
    • Memory impact: None; only passes an extra string and a null-coalesce.
    • Security: No new risks; only affects display titles.
    • Tests: No new unit tests.

Written for commit d0c30df. Summary will update on new commits.

@prlabeler prlabeler Bot added the bug Something isn't working label Mar 13, 2026
Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Quick Access Links names not updating Fix Quick Access Links of type File ignoring custom name in search results Mar 13, 2026
Copilot AI requested a review from VictoriousRaptor March 13, 2026 14:32
@Jack251970
Copy link
Copy Markdown
Member

@VictoriousRaptor Please close it and open a new PR of this branch. All changes look good to me.

@Jack251970 Jack251970 deleted the copilot/fix-quick-access-links-names branch March 15, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev: renamed file type Quick Access Links do not display the new names

3 participants