Skip to content

Remove Segoe UI font-family style for CJK Character Rendering#4376

Merged
Jack251970 merged 1 commit intodevfrom
RemoveFontFamily
Mar 23, 2026
Merged

Remove Segoe UI font-family style for CJK Character Rendering#4376
Jack251970 merged 1 commit intodevfrom
RemoveFontFamily

Conversation

@Jack251970
Copy link
Copy Markdown
Member

@Jack251970 Jack251970 commented Mar 23, 2026

Removed FontFamily, FontSize, and FontWeight properties from TitleTextBlock/TextBlock in MessageBoxEx.xaml, ProgressBoxEx.xaml, and SearchSourceSetting.xaml to use default font styling for correct CJK character rendering.

Used the same solution as #1427. No need to test.

Resolve #4373. Follow on with #1427.

Removed FontFamily, FontSize, and FontWeight properties from TitleTextBlock/TextBlock in MessageBoxEx.xaml, ProgressBoxEx.xaml, and SearchSourceSetting.xaml to use default font styling for titles.
Copilot AI review requested due to automatic review settings March 23, 2026 11:35
@github-actions github-actions bot added this to the 2.2.0 milestone Mar 23, 2026
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Mar 23, 2026

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/MessageBoxEx.xaml

Activity based on git-commit:

Jack251970
MAR
FEB
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 100%

Flow.Launcher/ProgressBoxEx.xaml

Activity based on git-commit:

Jack251970
MAR
FEB
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 100%

Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml

Activity based on git-commit:

Jack251970
MAR
FEB
JAN
DEC
NOV
OCT

Knowledge based on git-blame:
Jack251970: 100%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Mar 23, 2026

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970 Jack251970 enabled auto-merge March 23, 2026 11:36
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@Jack251970 Jack251970 changed the title Remove explicit font styles from title text elements Remove Segoe UI font-family style for CJK Character Rendering Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes hardcoded FontFamily="Segoe UI" from several title text elements so they inherit the system/default font, addressing CJK glyph rendering issues (Issue #4373) and aligning with prior work in #1427.

Changes:

  • Removed FontFamily="Segoe UI" from TitleTextBlock in MessageBoxEx.xaml.
  • Removed FontFamily="Segoe UI" from TitleTextBlock in ProgressBoxEx.xaml.
  • Removed FontFamily="Segoe UI" from a title TextBlock in SearchSourceSetting.xaml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Flow.Launcher/MessageBoxEx.xaml Drops hardcoded Segoe UI on the dialog title to allow OS font fallback for CJK.
Flow.Launcher/ProgressBoxEx.xaml Drops hardcoded Segoe UI on the progress dialog title to allow OS font fallback for CJK.
Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml Removes Segoe UI from a title text element to avoid hardcoded font usage in that window.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 89 to 93
Margin="0 0 26 0"
VerticalAlignment="Center"
FontFamily="Segoe UI"
FontSize="20"
FontWeight="SemiBold"
TextAlignment="Left"
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description say FontFamily, FontSize, and FontWeight were removed to use default title styling, but in this file the TitleTextBlock still hardcodes FontSize="20" and FontWeight="SemiBold" (only FontFamily was removed). Please either update the PR title/description to match the actual change (removing just Segoe UI), or remove the remaining explicit font styling if the intent is to rely on defaults.

Copilot uses AI. Check for mistakes.
@coderabbitai coderabbitai bot added the bug Something isn't working label Mar 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

Removes explicit FontFamily="Segoe UI" assignments from title TextBlocks in three XAML files to allow system default font inheritance, addressing CJK character rendering issues when hardcoded Segoe UI lacks proper glyph support for Chinese, Japanese, and Korean characters.

Changes

Cohort / File(s) Summary
Core UI Components
Flow.Launcher/MessageBoxEx.xaml, Flow.Launcher/ProgressBoxEx.xaml
Removed hardcoded FontFamily="Segoe UI" from title TextBlocks to enable system default font inheritance for improved CJK character rendering.
Plugin Settings
Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml
Removed explicit FontFamily="Segoe UI" from title TextBlock, allowing theme/style-based font selection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • onesounds
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR description claims to have removed FontSize and FontWeight properties, but the actual changes only removed FontFamily attributes. Verify whether FontSize and FontWeight were actually removed from all three files or clarify that only FontFamily was removed as the actual changes suggest.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing Segoe UI font-family assignments from UI elements for CJK character rendering.
Linked Issues check ✅ Passed The PR fulfills issue #4373's requirement to remove hardcoded FontFamily="Segoe UI" from TitleTextBlock in MessageBoxEx.xaml and extends the fix to ProgressBoxEx.xaml and SearchSourceSetting.xaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description accurately describes the changes made across all three XAML files (removing FontFamily, FontSize, and FontWeight properties) and provides context by referencing related issues #4373 and #1427.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch RemoveFontFamily

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jack251970 Jack251970 merged commit 1ddb605 into dev Mar 23, 2026
26 checks passed
@Jack251970 Jack251970 deleted the RemoveFontFamily branch March 23, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded Segoe UI font in MessageBoxEx causes CJK character rendering issues

3 participants