Remove Segoe UI font-family style for CJK Character Rendering#4376
Remove Segoe UI font-family style for CJK Character Rendering#4376Jack251970 merged 1 commit intodevfrom
Conversation
Removed FontFamily, FontSize, and FontWeight properties from TitleTextBlock/TextBlock in MessageBoxEx.xaml, ProgressBoxEx.xaml, and SearchSourceSetting.xaml to use default font styling for titles.
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
There was a problem hiding this comment.
Pull request overview
Removes hardcoded FontFamily="Segoe UI" from several title text elements so they inherit the system/default font, addressing CJK glyph rendering issues (Issue #4373) and aligning with prior work in #1427.
Changes:
- Removed
FontFamily="Segoe UI"fromTitleTextBlockinMessageBoxEx.xaml. - Removed
FontFamily="Segoe UI"fromTitleTextBlockinProgressBoxEx.xaml. - Removed
FontFamily="Segoe UI"from a titleTextBlockinSearchSourceSetting.xaml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Flow.Launcher/MessageBoxEx.xaml | Drops hardcoded Segoe UI on the dialog title to allow OS font fallback for CJK. |
| Flow.Launcher/ProgressBoxEx.xaml | Drops hardcoded Segoe UI on the progress dialog title to allow OS font fallback for CJK. |
| Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml | Removes Segoe UI from a title text element to avoid hardcoded font usage in that window. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Margin="0 0 26 0" | ||
| VerticalAlignment="Center" | ||
| FontFamily="Segoe UI" | ||
| FontSize="20" | ||
| FontWeight="SemiBold" | ||
| TextAlignment="Left" |
There was a problem hiding this comment.
PR title/description say FontFamily, FontSize, and FontWeight were removed to use default title styling, but in this file the TitleTextBlock still hardcodes FontSize="20" and FontWeight="SemiBold" (only FontFamily was removed). Please either update the PR title/description to match the actual change (removing just Segoe UI), or remove the remaining explicit font styling if the intent is to rely on defaults.
📝 WalkthroughWalkthroughRemoves explicit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed FontFamily, FontSize, and FontWeight properties from TitleTextBlock/TextBlock in MessageBoxEx.xaml, ProgressBoxEx.xaml, and SearchSourceSetting.xaml to use default font styling for correct CJK character rendering.
Used the same solution as #1427. No need to test.
Resolve #4373. Follow on with #1427.