Recover from task switcher issue with minimized windows

[DavidGBrett]

Catches case where window is activated but not restored / maximized and then manually does that

Partially resolves #4397

This doesn't fix the core issue but does recover from it to get to the desired state regardless.
There will still be an error sound, but the window will be restored/maximized based on the state it was before being minimized.

---

Summary by cubic

Fixes a rare Alt+Tab case where Settings and Plugin Settings stayed minimized after activation. On activation, each window restores to its last non-minimized state so it shows up in the task switcher.

• Summary of changes
  • Existing logic changed: PluginSettingsWindow now tracks the last non-minimized state in OnLoaded/Window_StateChanged; SettingWindow state persistence remains the same.
  • New logic added: Activated="Window_Activated" on both windows; on activation, if minimized, SettingWindow restores to _settings.SettingWindowState and PluginSettingsWindow restores to _lastNonMinimizedWindowState.
  • Existing logic removed: None.
  • Memory usage impact: Negligible (one new field in PluginSettingsWindow and one extra event subscription per window).
  • Security risks: None.
  • Unit tests: None added; behavior verified manually via Alt+Tab.

^{Written for commit 8783bac. Summary will update on new commits.}

[gitstream-cm]

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/PluginSettingsWindow.xaml

Activity based on git-commit:

	Jack251970
APR	288 additions & 306 deletions
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 82%

Flow.Launcher/PluginSettingsWindow.xaml.cs

Activity based on git-commit:

	Jack251970
APR
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:

Flow.Launcher/SettingWindow.xaml

Activity based on git-commit:

	Jack251970
APR
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 100%

Flow.Launcher/SettingWindow.xaml.cs

Activity based on git-commit:

	Jack251970
APR
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 99%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[cubic-dev-ai]

No issues found across 4 files

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds Activated event handlers to settings windows to restore a cached non-minimized WindowState when the window is activated while minimized, ensuring Alt+Tab activation correctly restores the window.

Changes

Cohort / File(s)	Summary
PluginSettingsWindow Flow.Launcher/PluginSettingsWindow.xaml, Flow.Launcher/PluginSettingsWindow.xaml.cs	Hooked Activated="Window_Activated" in XAML and added Window_Activated logic plus a _lastNonMinimizedWindowState cache to restore state when activation occurs while minimized.
SettingWindow Flow.Launcher/SettingWindow.xaml, Flow.Launcher/SettingWindow.xaml.cs	Hooked Activated="Window_Activated" in XAML and added Window_Activated handler to restore persisted non-minimized state on activation when current state is minimized.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix setting window freeze issue & Improve singleton window opener #3204: Related changes addressing minimize/restore behavior; both PRs adjust how minimized windows are handled during activation.
• Fix settings window is minimized when re-opened. #4341: Also addresses minimized settings-window behavior by altering state persistence/restore logic.

Suggested reviewers

• Yusyuriv
• jjw24
• Jack251970

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, explaining the problem, the solution approach, and acknowledging it as a partial fix.
Linked Issues check	✅ Passed	The changes directly address the core requirement from #4397: enabling minimized Settings and Plugin Settings windows to be restored via Alt+Tab activation.
Out of Scope Changes check	✅ Passed	All changes are scoped to the stated objective: adding Window_Activated handlers to both SettingWindow and PluginSettingsWindow to restore minimized windows on activation.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: recovering minimized windows from a task switcher issue via Activated event handlers.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Flow.Launcher/PluginSettingsWindow.xaml.cs`:
- Around line 95-104: The restore logic in Window_Activated uses
_settings.SettingWindowState (global SettingWindow history) which can reopen
PluginSettingsWindow with the wrong state; add a PluginSettingsWindow-local
field (e.g., _lastNonMinimizedState) that you update whenever this window's
StateChanged handler sees a non-minimized state, and change Window_Activated to
restore WindowState from that local field instead of
_settings.SettingWindowState; update any StateChanged or closing logic in the
PluginSettingsWindow class to maintain _lastNonMinimizedState so the window
reliably returns to its own last non-minimized state.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e62d825-f765-456b-a5bf-d6a32c0d4403

📥 Commits

Reviewing files that changed from the base of the PR and between 3e320d5 and e3dc615.

📒 Files selected for processing (4)

• Flow.Launcher/PluginSettingsWindow.xaml
• Flow.Launcher/PluginSettingsWindow.xaml.cs
• Flow.Launcher/SettingWindow.xaml
• Flow.Launcher/SettingWindow.xaml.cs

[cubic-dev-ai]

No issues found across 4 files