Skip to content

Fix icon binding in Plugin Store Settings Pane#4405

Merged
Jack251970 merged 1 commit intoFlow-Launcher:devfrom
DavidGBrett:fix-plugin-store-icons
Apr 10, 2026
Merged

Fix icon binding in Plugin Store Settings Pane#4405
Jack251970 merged 1 commit intoFlow-Launcher:devfrom
DavidGBrett:fix-plugin-store-icons

Conversation

@DavidGBrett
Copy link
Copy Markdown
Contributor

@DavidGBrett DavidGBrett commented Apr 10, 2026

Change

Use IcoPath instead of non-existent IcoPathAbsolute

(This seems to be an issue only on the current dev branch, not the latest release)

UI

Before

image

After

image

Use IcoPath instead of non existent IcoPathAbsolute
@prlabeler prlabeler bot added the bug Something isn't working label Apr 10, 2026
@github-actions github-actions bot added this to the 2.2.0 milestone Apr 10, 2026
@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 2
⚠️ non-alpha-in-dictionary 2

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Pattern
\b[Nn]o[nt][- ]existent\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@DavidGBrett DavidGBrett marked this pull request as ready for review April 10, 2026 17:01
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Apr 10, 2026

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml

Activity based on git-commit:

Jack251970
APR
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 100%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Apr 10, 2026

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a950e20a-dc80-449f-ab54-26875c9f5484

📥 Commits

Reviewing files that changed from the base of the PR and between 3e320d5 and f949b1c.

📒 Files selected for processing (1)
  • Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml

📝 Walkthrough

Walkthrough

The plugin icon image binding in the plugin store settings pane is updated to use IcoPath instead of IcoPathAbsolute, with all other image binding properties and layout configurations remaining unchanged.

Changes

Cohort / File(s) Summary
Plugin Store Settings UI
Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml
Updated Image.Source binding from IcoPathAbsolute to IcoPath while preserving async image loading and existing layout/render properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Return data uri image as icon support #3104: Introduces changes to allow data:image URIs through Result.IcoPath logic and ImageLoader handling, which directly relates to this binding switch from IcoPathAbsolute to IcoPath.

Suggested reviewers

  • VictoriousRaptor
  • Jack251970
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: fixing icon binding in the Plugin Store Settings Pane, which matches the core of the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific property change from IcoPathAbsolute to IcoPath and providing before/after UI screenshots demonstrating the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Jack251970 Jack251970 added Dev branch only An issue or fix for the Dev branch build and removed bug Something isn't working labels Apr 10, 2026
@Jack251970 Jack251970 merged commit f6b200b into Flow-Launcher:dev Apr 10, 2026
10 checks passed
@Jack251970
Copy link
Copy Markdown
Member

Thanks for your fix!

@DavidGBrett
Copy link
Copy Markdown
Contributor Author

Happy to help! @Jack251970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev branch only An issue or fix for the Dev branch build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants