Experimental Changes to Avalonia#4562
Draft
taooceros wants to merge 5 commits into
Draft
Conversation
8209c38 to
f787603
Compare
cd86075 to
3e7be8e
Compare
f787603 to
7640806
Compare
3e7be8e to
88ea811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings.LastQueryModein AvaloniaMainViewModel.Show()/Hide()instead of always clearingQueryTextQueryTextFocusRequestown the first visible show:Show()/ShowWithInjectedQuery(...)now raise the focus request beforeMainWindowVisibility = true, so theIsVisiblebinding cannot reveal the window before stagingTextBox.Texttarget to the ViewModel query text, wait untilDispatcherPriority.ContextIdlebefore applying focus/selection, then reveal at render priorityLastQueryMode.Selected, apply the pre-hide select-all request whileMainWindowVisibilityis still true, then hide; next show uses focus-only mode when selection is already preparedQueryTextFocusRequestpath; no DWM cloak is usedVerification
dotnet test Flow.Launcher.Test/Flow.Launcher.Test.csproj --no-restore --filter FullyQualifiedName~Flow.Launcher.Test.Avalonia.MainViewModelLastQueryModeTestdotnet build Flow.Launcher.Avalonia/Flow.Launcher.Avalonia.csproj -c Debug --no-restore