fix lint

Author: hardillb

forge/ee/lib/sso/index.js

@@ -441,7 +441,6 @@ module.exports.init = async function (app) {
         const desiredTeamMemberships = {}
         const groupRegEx = /^ff-(.+)-([^-]+)$/
         for (const i in searchEntries) {
-            
             const match = groupRegEx.exec(searchEntries[i].cn)
             if (match) {
                 app.log.debug(`Found group ${searchEntries[i].cn} for user ${user.username}`)
@@ -533,10 +532,10 @@ module.exports.init = async function (app) {
             }
         }
         // - Check remaining desired memberships
-            //   - create membership
-            for (const [teamSlug, teamRole] of Object.entries(desiredTeamMemberships)) {
-                // This is a new team membership
-                promises.push(app.db.models.Team.bySlug(teamSlug).then(team => {
+        //   - create membership
+        for (const [teamSlug, teamRole] of Object.entries(desiredTeamMemberships)) {
+            // This is a new team membership
+            promises.push(app.db.models.Team.bySlug(teamSlug).then(team => {
                 if (team) {
                     // console.log(`adding to team ${teamSlug} role ${teamRole}`)
                     return app.db.controllers.Team.addUser(team, user, teamRole).then(() => {

frontend/src/pages/admin/Settings/SSO/createEditProvider.vue

@@ -214,14 +214,10 @@ export default {
             return this.$route.params.id === 'create'
         },
         isGroupOptionsValid () {
-            try {
             return !this.input.options.groupMapping || (
-                (this.input.options.type === 'saml' ? this.isGroupAssertionNameValid : this.isGroupsDNValid)
-                && this.isGroupAdminNameValid
+                (this.input.options.type === 'saml' ? this.isGroupAssertionNameValid : this.isGroupsDNValid) &&
+                  this.isGroupAdminNameValid
             )
-            } catch (eee) {
-                console.log(eee)
-            }
         },
         isGroupAssertionNameValid () {
             return this.input.options.groupAssertionName && this.input.options.groupAssertionName.length > 0
@@ -236,11 +232,7 @@ export default {
             return !this.isGroupsDNValid ? 'Group DN is required' : ''
         },
         isGroupAdminNameValid () {
-            try {
-                return !this.input.options.groupAdmin || (this.input.options.groupAdminName && this.input.options.groupAdminName.length > 0)
-            } catch (eee) {
-                console.log(eee)
-            }
+            return !this.input.options.groupAdmin || (this.input.options.groupAdminName && this.input.options.groupAdminName.length > 0)
         },
         groupAdminNameError () {
             return !this.isGroupAdminNameValid ? 'Admin Group name is required' : ''