Add lastSeenAt to device and snapshot creation in e2e tests for better timestamp tracking

Author: cstns

test/e2e/frontend/environments/standard.js

@@ -191,26 +191,26 @@ module.exports = async function (settings = {}, config = {}) {
     }
 
     // Unassigned devices
-    await factory.createDevice({ name: 'team2-unassigned-device', type: 'type2' }, team2)
-    await factory.createDevice({ name: 'team2-unassigned-device-bulk-test-1', type: 'type2' }, team2)
+    await factory.createDevice({ name: 'team2-unassigned-device', type: 'type2', lastSeenAt: Date.now() }, team2)
+    await factory.createDevice({ name: 'team2-unassigned-device-bulk-test-1', type: 'type2', lastSeenAt: Date.now() }, team2)
 
     // Application and Instances
     const application2 = await factory.createApplication({ name: 'application-2' }, team2, stack, template, projectType)
     await factory.createInstance({ name: 'instance-2-1' }, application2, stack, template, projectType)
 
     const instanceWithDevices = await factory.createInstance({ name: 'instance-2-with-devices' }, application2, stack, template, projectType, { start: false })
-    await factory.createDevice({ name: 'assigned-device-a', type: 'type2' }, team2, instanceWithDevices)
-    await factory.createDevice({ name: 'assigned-device-b', type: 'type2' }, team2, instanceWithDevices)
-    await factory.createDevice({ name: 'assigned-device-c', type: 'type2' }, team2, instanceWithDevices)
-    await factory.createDevice({ name: 'assigned-device-d-bulk-test-2', type: 'type2' }, team2, instanceWithDevices)
+    await factory.createDevice({ name: 'assigned-device-a', type: 'type2', lastSeenAt: Date.now() }, team2, instanceWithDevices)
+    await factory.createDevice({ name: 'assigned-device-b', type: 'type2', lastSeenAt: Date.now() }, team2, instanceWithDevices)
+    await factory.createDevice({ name: 'assigned-device-c', type: 'type2', lastSeenAt: Date.now() }, team2, instanceWithDevices)
+    await factory.createDevice({ name: 'assigned-device-d-bulk-test-2', type: 'type2', lastSeenAt: Date.now() }, team2, instanceWithDevices)
     await factory.createSnapshot({ name: 'snapshot 1' }, instanceWithDevices, userBob)
     await factory.createSnapshot({ name: 'snapshot 2' }, instanceWithDevices, userBob)
     await factory.createSnapshot({ name: 'snapshot 3' }, instanceWithDevices, userBob)
 
     // create devices bound to application directly
-    const deviceA = await factory.createDevice({ name: 'application-device-a', type: 'type2' }, team2, null, application2)
-    const deviceB = await factory.createDevice({ name: 'application-device-b', type: 'type2' }, team2, null, application2)
-    await factory.createDevice({ name: 'application-device-c-bulk-test-3', type: 'type2' }, team2, null, application2)
+    const deviceA = await factory.createDevice({ name: 'application-device-a', type: 'type2', lastSeenAt: Date.now() }, team2, null, application2)
+    const deviceB = await factory.createDevice({ name: 'application-device-b', type: 'type2', lastSeenAt: Date.now() }, team2, null, application2)
+    await factory.createDevice({ name: 'application-device-c-bulk-test-3', type: 'type2', lastSeenAt: Date.now() }, team2, null, application2)
 
     // create a device group and add deviceB to it
     const deviceGroupA = await factory.createApplicationDeviceGroup({ name: 'application-device-group-a' }, application2)

test/e2e/frontend/lib/rbacTeamFactory.js

@@ -172,7 +172,8 @@ module.exports = async function (forge) {
         // Create devices
         const appDevice = await factory.createDevice({
             name: `${name}-app-device`,
-            type: 'type2'
+            type: 'type2',
+            lastSeenAt: Date.now()
         }, rbacTeam, null, application)
 
         const instanceDevice = await factory.createDevice({
@@ -182,7 +183,7 @@ module.exports = async function (forge) {
 
         // Create snapshots
         await factory.createSnapshot({ name: 'snapshot 1' }, instance, ownerOwen)
-        await factory.createDeviceSnapshot({ name: 'device snapshot 1' }, appDevice, ownerOwen)
+        await factory.createDeviceSnapshot({ name: 'device snapshot 1', lastSeenAt: Date.now() }, appDevice, ownerOwen)
 
         // create Device Groups
         await factory.createApplicationDeviceGroup({

test/e2e/frontend/test_environment_ee.js

@@ -158,7 +158,7 @@ if (fs.existsSync(configPath)) {
 
     // create a snapshot on DeviceB
     const deviceB = flowforge.applicationDevices.find((device) => device.name === 'application-device-b')
-    await factory.createDeviceSnapshot({ name: 'application-device-b snapshot 1' }, deviceB, userTerry)
+    await factory.createDeviceSnapshot({ name: 'application-device-b snapshot 1', lastSeenAt: Date.now() }, deviceB, userTerry)
 
     rbacTeamFactory(flowforge)
 

test/lib/TestModelFactory.js

@@ -208,8 +208,7 @@ module.exports = class TestModelFactory {
             name: 'unnamed-device',
             type: 'unnamed-type',
             credentialSecret: '',
-            agentVersion: '1.11.0',
-            lastSeenAt: Date.now()
+            agentVersion: '1.11.0'
         }
         const device = await this.forge.db.models.Device.create({
             ...defaultDeviceDetails,