Skip to content

Commit 7ed08a3

Browse files
authored
Merge pull request #6624 from FlowFuse/chore/extract-immersive-editor-components-into-a-global-namespace
Relocate immersive editor components to a common namespace
2 parents 872fe86 + baaa44e commit 7ed08a3

7 files changed

Lines changed: 8 additions & 24 deletions

File tree

frontend/src/pages/instance/Editor/components/drawer/ResizeBar.vue renamed to frontend/src/components/ResizeBar.vue

File renamed without changes.

frontend/src/components/expert/ExpertChatInput.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ import { mapGetters } from 'vuex'
6565
6666
import { useResizingHelper } from '../../composables/ResizingHelper.js'
6767
68-
import ResizeBar from '../../pages/instance/Editor/components/drawer/ResizeBar.vue'
68+
import ResizeBar from '../ResizeBar.vue'
6969
7070
import CapabilitiesSelector from './components/CapabilitiesSelector.vue'
7171
import IncludeSelectionButton from './components/IncludeSelectionButton.vue'

frontend/src/pages/instance/Editor/components/DrawerTrigger.vue renamed to frontend/src/components/immersive-editor/DrawerTrigger.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
type="button"
99
@click="$emit('toggle')"
1010
>
11-
<img src="../../../../images/icons/ff-minimal-grey.svg" alt="FlowFuse logo">
11+
<img src="../../images/icons/ff-minimal-grey.svg" alt="FlowFuse logo">
1212
<ChevronRightIcon class="ff-btn--icon" />
1313
</button>
1414
</template>

frontend/src/pages/instance/Editor/components/EditorWrapper.vue renamed to frontend/src/components/immersive-editor/HostedInstanceEditorWrapper.vue

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const States = {
3737
STOPPING: 'stopping'
3838
}
3939
export default {
40-
name: 'EditorWrapper',
40+
name: 'HostedInstanceEditorWrapper',
4141
components: { LoadingScreenWrapper },
4242
inject: ['$services'],
4343
props: {
@@ -116,18 +116,3 @@ export default {
116116
}
117117
}
118118
</script>
119-
120-
<style scoped lang="scss">
121-
.editor-wrapper {
122-
height: 100%;
123-
width: 100%;
124-
position: absolute;
125-
display: flex;
126-
flex-direction: column;
127-
align-content: center;
128-
justify-content: center;
129-
}
130-
.editor-wrapper .status-wrapper {
131-
margin-top: -64px;
132-
}
133-
</style>

frontend/src/pages/instance/Editor/components/LoadingScreenWrapper.vue renamed to frontend/src/components/immersive-editor/LoadingScreenWrapper.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</template>
2121

2222
<script>
23-
import InstanceStatusBadge from '../../components/InstanceStatusBadge.vue'
23+
import InstanceStatusBadge from '../../pages/instance/components/InstanceStatusBadge.vue'
2424
2525
export default {
2626
name: 'LoadingScreenWrapper',
@@ -66,7 +66,7 @@ export default {
6666
},
6767
animationData () {
6868
try {
69-
return require(`../../../../images/lottie/immersive-editor-loading-states/${this.computedState}.json`)
69+
return require(`../../images/lottie/immersive-editor-loading-states/${this.computedState}.json`)
7070
} catch (error) {
7171
return null
7272
}

frontend/src/pages/instance/Editor/components/drawer/MiddleCloseButton.vue renamed to frontend/src/components/immersive-editor/drawer/MiddleCloseButton.vue

File renamed without changes.

frontend/src/pages/instance/Editor/index.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,10 @@ import { ArrowLeftIcon, XIcon } from '@heroicons/vue/solid'
7272
import { mapActions, mapGetters } from 'vuex'
7373
7474
import InstanceStatusPolling from '../../../components/InstanceStatusPolling.vue'
75+
import ResizeBar from '../../../components/ResizeBar.vue'
7576
import ExpertTabIcon from '../../../components/icons/ff-minimal-grey.js'
77+
import DrawerTrigger from '../../../components/immersive-editor/DrawerTrigger.vue'
78+
import EditorWrapper from '../../../components/immersive-editor/HostedInstanceEditorWrapper.vue'
7679
import InstanceActionsButton from '../../../components/instance/ActionButton.vue'
7780
import { useDrawerHelper } from '../../../composables/DrawerHelper.js'
7881
import usePermissions from '../../../composables/Permissions.js'
@@ -85,10 +88,6 @@ import { Roles } from '../../../utils/roles.js'
8588
import ConfirmInstanceDeleteDialog from '../Settings/dialogs/ConfirmInstanceDeleteDialog.vue'
8689
import DashboardLink from '../components/DashboardLink.vue'
8790
88-
import DrawerTrigger from './components/DrawerTrigger.vue'
89-
import EditorWrapper from './components/EditorWrapper.vue'
90-
import ResizeBar from './components/drawer/ResizeBar.vue'
91-
9291
// Drawer size constraints
9392
const DRAWER_MIN_WIDTH = 310 // Minimum drawer width in pixels
9493
const DRAWER_DEFAULT_WIDTH = 550 // Default drawer width in pixels

0 commit comments

Comments
 (0)