Run the e2e smtp servers only when configured to do so#5457
Merged
knolleary merged 4 commits intoApr 29, 2025
Conversation
- added a new isEmailEnabled cypress command that checks if email is configured - skipping tests that need email config when not configured locally - running smtp containers only if configured in the yml file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5457 +/- ##
=======================================
Coverage 77.31% 77.31%
=======================================
Files 350 350
Lines 16583 16583
Branches 3865 3865
=======================================
Hits 12821 12821
Misses 3762 3762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 23, 2025
knolleary
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Smtp containers will run only if the following configuration is present in the
etc/flowforge.local.yml file:This allows a granular approach to testing
Related Issue(s)
docs update FlowFuse/website#3188
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel