feat: Move to Role from ClusterRole#913
Open
hardillb wants to merge 4 commits into
Open
Conversation
fixes FlowFuse/flowfuse#7235 This reduces the scope of the permissions granted to the Forge app to just the ProjectNamespace
hardillb
changed the title
hardillb
changed the title
Contributor
Author
|
I need to double check test this, but I'm 95% sure it's all good. |
ppawlowski
requested changes
May 27, 2026
| @@ -72,6 +72,6 @@ subjects: | |||
| name: flowforge | |||
| namespace: {{ .Release.Namespace }} | |||
| roleRef: | |||
Contributor
There was a problem hiding this comment.
Upgrading helm release with a custom clusterRole.name defined causes upgrade failure, see https://github.com/FlowFuse/flowfuse/actions/runs/26503988570/job/78052046575#step:15:41
| kind: ClusterRole | ||
| kind: Role | ||
| metadata: | ||
| name: {{ ((.Values.forge).clusterRole).name | default "create-pod" }} |
Contributor
There was a problem hiding this comment.
We will still use forge.clusterRole to define the Role name. Changing this will introduce a braking change. I think we should at least mention in the Readme that this will affect Role resource creation, not ClusterRole.
hardillb
commented
May 27, 2026
Co-authored-by: Piotr Pawlowski <ppawlowski@users.noreply.github.com> Co-authored-by: Ben Hardill <b.hardill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes FlowFuse/flowfuse#7235
Description
This reduces the scope of the permissions granted to the Forge app to just the ProjectNamespace
Related Issue(s)
FlowFuse/flowfuse#7235
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel