Skip to content

MES Solutions page#3151

Merged
gstout52 merged 12 commits into
mainfrom
320-solutions-page-mes
Apr 18, 2025
Merged

MES Solutions page#3151
gstout52 merged 12 commits into
mainfrom
320-solutions-page-mes

Conversation

@Yndira-E
Copy link
Copy Markdown
Contributor

Description

This PR introduces the solution page for MES.

Related Issue(s)

https://github.com/FlowFuse/customer/issues/320

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E requested a review from gstout52 April 15, 2025 14:31
@Yndira-E
Copy link
Copy Markdown
Contributor Author

@gstout52 I'm keeping it as a draft until the diagram is ready.

@Yndira-E Yndira-E marked this pull request as ready for review April 17, 2025 10:49
@github-actions
Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 33.7%, saving 37.82 KB.

Filename Before After Improvement Visual comparison
src/images/solutions/mes-hero.png 112.15 KB 74.33 KB -33.7% View diff

1717 images did not require optimisation.

@Yndira-E
Copy link
Copy Markdown
Contributor Author

@gstout52 If the diagram is ok, it should be good to go.

@gstout52
Copy link
Copy Markdown
Contributor

@Yndira-E Can you separate "Dashboard" and "Analytics" so that they appear one on top of another, rather than as "Dashboard Analytics"? Other than that, I feel good to publish this.

@Yndira-E
Copy link
Copy Markdown
Contributor Author

Done!

@github-actions
Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 33.8%, saving 38.14 KB.

Filename Before After Improvement Visual comparison
src/images/solutions/mes-hero.png 112.85 KB 74.71 KB -33.8% View diff

1717 images did not require optimisation.

@github-actions
Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 40.7%, saving 123.00 KB.

Filename Before After Improvement Visual comparison
src/images/solutions/oee-dashboard--1.png 302.38 KB 179.38 KB -40.7% View diff

1718 images did not require optimisation.

@gstout52 gstout52 closed this Apr 18, 2025
@gstout52 gstout52 reopened this Apr 18, 2025
@gstout52 gstout52 merged commit 77f485c into main Apr 18, 2025
8 checks passed
@gstout52 gstout52 deleted the 320-solutions-page-mes branch April 18, 2025 15:18
@Yndira-E
Copy link
Copy Markdown
Contributor Author

@gstout52 @sumitshinde-84 Could you please clarify the reasoning behind the image layout changes? The design was approved before I started the development work on the page.

Also, Sumit — just a quick note: the dashboard image didn’t need to be added manually. I had already configured it to pull from the blueprints repository to avoid duplication. The reason it doesn’t show in the preview is because the repository isn’t available in that environment. That’s why I created the global deployPreview property — it skips the image only in previews to avoid errors.

@gstout52
Copy link
Copy Markdown
Contributor

gstout52 commented May 2, 2025

@Yndira-E , the design was not displaying properly in the preview when it was time to merge, so I asked Sumit to move things around to keep the intent of the original design. The goal wasn't to completely rewrite your design, but to come up with an alternative that captured the spirit of the original and could be merged.

@Yndira-E
Copy link
Copy Markdown
Contributor Author

Yndira-E commented May 2, 2025

Thanks for the background Greg, now I understand I can change it back to the original design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants